WIP

resources/bytecode/javFiles/Bug389.jav

@@ -0,0 +1,10 @@
+import java.lang.String;
+
+public class Bug389 {
+    public swap(f) {
+        return x -> y -> f.apply(y).apply(x);
+    }
+    public swap(f) {
+        return x -> y -> z -> f.apply(z).apply(x).apply(y);
+    }
+}

resources/bytecode/javFiles/Bug389Main.jav

@@ -0,0 +1,12 @@
+import Bug389;
+import java.util.List;
+import java.lang.String;
+import java.lang.Integer;
+
+public class Bug389Main {
+    public static main(args) {
+        var func = x -> y -> z -> x + y + z;
+        var swap = new Bug389();
+        swap.swap(func).apply(1).apply(2).apply(3);
+    }
+}

resources/bytecode/javFiles/PatternMatching.jav

@@ -1,14 +1,13 @@
-sealed interface List<T> permits Cons, Empty {}
-
-public record Cons<T>(T a, List<T> l) implements List<T> {}
-public record Empty<T>() implements List<T> {}
-public record Tuple<T1, T2>(T1 a, T2 b) {}
+import Cons;
+import Empty;
+import List;
+import Pair;
 
 public class PatternMatching {
     public zip(Cons(x, xs), Cons(y, ys)) {
-        return new Cons(new Tuple(x, y), zip(xs, ys));
+        return new Cons<>(new Pair<>(x, y), zip(xs, ys));
     }
-    public zip(Empty x, Empty y) { return new Empty(); }
+    public zip(Empty x, Empty y) { return new Empty<>(); }
 
     /*public zip(Empty x, Cons y) { return new Empty(); }
     public zip(Cons x, Empty y) { return new Empty(); }

resources/bytecode/javFiles/PatternMatchingJava.jav

@@ -2,18 +2,24 @@ import java.lang.Object;
 import List;
 import Cons;
 import Empty;
-import Tuple;
+import Pair;
 
 public class PatternMatchingJava {
-    public zip(a, b) {
+    public <A, B> Cons<Pair<A, B>> zip(Cons<A> a, Cons<B> b) {
         switch (a) {
             case Cons(x, Cons xs) -> {
                 switch (b) {
-                    case Cons(y, Cons ys) -> { return new Cons<>(new Tuple<>(x, y), zip(xs, ys)); }
-                    case Cons(y, Empty()) -> { return new Empty<>(); }
+                    case Cons(y, Cons ys) -> { return new Cons<>(new Pair<>(x, y), zip(xs, ys)); }
                 };
             }
-            case Cons(x, Empty()) -> { return new Empty<>(); }
+            case Cons(x, Empty xs) -> {
+                switch (b) {
+                    case Cons(y, Empty ys) -> { return new Cons<>(new Pair<>(x, y), zip(xs, ys)); }
                 };
             }
+        };
+    }
+    public <A, B> Empty<Pair<A, B>> zip(Empty<A> a, Empty<B>) {
+        return new Empty<>();
+    }
 }

resources/bytecode/javFiles/PatternMatchingJava2.jav

@@ -1,5 +1,5 @@
-sealed interface List<T> permits Cons, Empty {}
+public sealed interface List<T> permits Cons, Empty {}
 
 public record Cons<T>(T a, List<T> l) implements List<T> {}
 public record Empty<T>() implements List<T> {}
-public record Tuple<T1, T2>(T1 a, T2 b) {}
+public record Pair<T1, T2>(T1 a, T2 b) {}

src/main/java/de/dhbwstuttgart/bytecode/Codegen.java

@@ -4,6 +4,7 @@ import de.dhbwstuttgart.core.JavaTXCompiler;
 import de.dhbwstuttgart.exceptions.NotImplementedException;
 import de.dhbwstuttgart.parser.scope.JavaClassName;
 import de.dhbwstuttgart.syntaxtree.ClassOrInterface;
+import de.dhbwstuttgart.syntaxtree.Pattern;
 import de.dhbwstuttgart.target.generate.ASTToTargetAST;
 import de.dhbwstuttgart.target.tree.*;
 import de.dhbwstuttgart.target.tree.expression.*;

src/main/java/de/dhbwstuttgart/core/JavaTXCompiler.java

@@ -422,43 +422,6 @@ public class JavaTXCompiler {
 		return typeInference(List.of(file));
 	}
 
-	public static String constraintSetToDot(ConstraintSet<Pair> c){
-
-		Iterator<String> colors = List.of(
-    "#FF0000", "#FF7F00", "#FFFF00", "#7FFF00", "#00FF00", "#00FF7F", "#00FFFF", "#007FFF",
-    "#0000FF", "#7F00FF", "#FF00FF", "#FF007F", "#BF0000", "#BF5F00", "#BFBF00", "#5FBF00",
-    "#00BF00", "#00BF5F", "#00BFBF", "#005FBF", "#0000BF", "#5F00BF", "#BF00BF", "#BF005F",
-    "#800000", "#804000", "#808000", "#408000", "#008000", "#008040", "#008080", "#004080",
-    "#000080", "#400080", "#800080", "#800040", "#FF4040", "#FF8040", "#FFFF40", "#80FF40",
-    "#40FF40", "#40FF80", "#40FFFF", "#4080FF", "#4040FF", "#8040FF", "#FF40FF", "#FF4080",
-    "#BF4040", "#BF8040", "#BFBF40", "#80BF40", "#40BF40", "#40BF80", "#40BFBF", "#4080BF",
-    "#4040BF", "#8040BF", "#BF40BF", "#BF4080", "#FF8080", "#FFBF80", "#FFFF80", "#BFFF80",
-    "#80FF80", "#80FFBF", "#80FFFF", "#80BFFF", "#8080FF", "#BF80FF", "#FF80FF", "#FF80BF").iterator();
-
-		StringBuilder sb = new StringBuilder();
-
-		sb.append("diagraph G{");
-
-		//and constraints to dot
-		sb.append(c.getUndConstraints().stream().map(Pair::toDot).collect(Collectors.joining("\n")));
-
-		//or constraints to dot
-		for (var orConstSet : c.getOderConstraints()){
-			for(var cons : orConstSet){
-				String color = colors.next();
-				sb.append(cons.stream().map(x -> x.toDot(color)).collect(Collectors.joining("\n")));
-			}
-		}
-
-		sb.append("}");
-
-		return sb.toString();
-	}
-
-	public static String q(String s) {
-		return "\"" + s.replace("\"", "\\\"") + "\"";
-	}
-
 	public List<ResultSet> typeInference(List<File> files) throws ClassNotFoundException, IOException {
 		Set<ClassOrInterface> allClasses = new HashSet<>();
 
@@ -475,36 +438,6 @@ public class JavaTXCompiler {
 		TYPE ty = new TYPE(definedClasses, allClasses);
 		var cons = ty.getConstraints();
 
-		var ANDconstraints = cons.getUndConstraints();
-		var ORConstraints = cons.getOderConstraints();
-
-		var orIterator = ORConstraints.iterator();
-
-		while(orIterator.hasNext()){
-			Set<Constraint<Pair>> y = orIterator.next();
-			if (y.isEmpty()) orIterator.remove();
-			else if (y.size() == 1){
-				ANDconstraints.addAll(y.iterator().next()); // add the OR constraint to the AND constraint since we only have one option
-				orIterator.remove();
-			}
-		}
-
-		String dot = constraintSetToDot(cons);
-
-
-		ANDconstraints.forEach(System.out::println);
-
-		for (var orc : ORConstraints){
-			System.out.println();
-			System.out.println("------");
-			System.out.println();
-			for(var hashs : orc){
-				System.out.print(hashs);
-				System.out.print("\n | \n");
-			}
-		}
-
-
 		Set<Set<UnifyPair>> results = new HashSet<>();
 		PlaceholderRegistry placeholderRegistry = new PlaceholderRegistry();
 

src/main/java/de/dhbwstuttgart/parser/SyntaxTreeGenerator/StatementGenerator.java

@@ -700,7 +700,7 @@ public class StatementGenerator {
         case ConditionalassignexpressionContext condassign:
             return convert(condassign);
         default:
-            throw new NotImplementedException();
+            throw new NotImplementedException(expression.getClass().toString());
         }
     }
 

src/main/java/de/dhbwstuttgart/parser/SyntaxTreeGenerator/TypeGenerator.java

@@ -64,6 +64,8 @@ public class TypeGenerator {
             switch (typeContext.primitiveType().getText()) {
             case "boolean":
                 return new RefType(ASTFactory.createClass(Boolean.class).getClassName(), typeContext.getStart());
+            case "char":
+                return new RefType(ASTFactory.createClass(Character.class).getClassName(), typeContext.getStart());
             case "int":
                 return new RefType(ASTFactory.createClass(Integer.class).getClassName(), typeContext.getStart());
             case "double":
@@ -71,7 +73,7 @@ public class TypeGenerator {
             case "float":
                 return new RefType(ASTFactory.createClass(Float.class).getClassName(), typeContext.getStart());
             default:
-                throw new NotImplementedException();
+                throw new NotImplementedException(typeContext.primitiveType().getText());
             }
         } else if (!typeContext.LBRACK().isEmpty()) { // ArrayType über eckige Klammer prüfen
             // JavaTXParser.logger.info(unannTypeContext.getText());

src/main/java/de/dhbwstuttgart/syntaxtree/factory/ASTFactory.java

@@ -229,9 +229,6 @@ public class ASTFactory {
 	public static Method createMethod(java.lang.reflect.Method jreMethod, String signature, java.lang.Class inClass, Boolean isInherited, Boolean isImplemented) {
 		String name = jreMethod.getName();
 		RefTypeOrTPHOrWildcardOrGeneric returnType;
-		if (inClass.getName().equals("Swap")){
-			System.out.println();
-		}
 		Type jreRetType;
 		if (jreMethod.getGenericReturnType() != null) {
 			jreRetType = jreMethod.getGenericReturnType();

src/main/java/de/dhbwstuttgart/syntaxtree/statement/MethodCall.java

@@ -28,6 +28,7 @@ public class MethodCall extends Statement
     
     //sind Tphs, repraesentieren im Resultset die Signatur der aufgerufenen Methoden, letztes Element ist der Returntyp
     public final ArrayList<TypePlaceholder> signature;
+    public int modifiers;
     
     public MethodCall(RefTypeOrTPHOrWildcardOrGeneric retType, Receiver receiver, String methodName, ArgumentList argumentList,
     		          RefTypeOrTPHOrWildcardOrGeneric receiverType, ArrayList<TypePlaceholder> signature, Token offset){

src/main/java/de/dhbwstuttgart/target/generate/ASTToTargetAST.java

@@ -65,6 +65,10 @@ public class ASTToTargetAST {
         public Generics(JavaTXCompiler compiler, ResultSet set) {
             this(new JavaGenerics(compiler, set), new TxGenerics(compiler, set));
         }
+
+        public static Generics nullGenerics() {
+            return new Generics(null, new ResultSet(Set.of()));
+        }
     }
 
     public IByteArrayClassLoader classLoader;
@@ -94,10 +98,15 @@ public class ASTToTargetAST {
         tphsInMethods.put(currentMethod, set);
     }
 
+    public static Optional<Method> findMethod(ClassOrInterface owner, String name, List<TargetType> argumentList, JavaTXCompiler compiler) {
+        return findMethod(owner, name, argumentList, Generics.nullGenerics().javaGenerics(), compiler);
+    }
+
     public static Optional<Method> findMethod(ClassOrInterface owner, String name, List<TargetType> argumentList, IGenerics generics, JavaTXCompiler compiler) {
         Optional<Method> method = Optional.empty();
         while (method.isEmpty()) {
-            method = owner.getMethods().stream().filter(m -> m.name.equals(name) && parameterEquals(m.getParameterList(), argumentList, generics)).findFirst();
+            method = owner.getMethods().stream().filter(m -> m.name.equals(name) &&
+                    parameterEquals(m.getParameterList().getFormalparalist().stream().map(p -> generics.getTargetType(p.getType())).toList(), argumentList)).findFirst();
             if (owner.getClassName().toString().equals("java.lang.Object")) break;
             owner = compiler.getClass(owner.getSuperClass().getName());
         }
@@ -105,16 +114,16 @@ public class ASTToTargetAST {
     }
 
     Optional<Constructor> findConstructor(ClassOrInterface owner, List<TargetType> argumentList, IGenerics generics) {
-        return owner.getConstructors().stream().filter(c -> parameterEquals(c.getParameterList(), argumentList, generics)).findFirst();
+        return owner.getConstructors().stream().filter(c ->
+                parameterEquals(c.getParameterList().getFormalparalist().stream().map(p -> generics.getTargetType(p.getType())).toList(), argumentList)).findFirst();
     }
 
-    static boolean parameterEquals(ParameterList parameterList, List<TargetType> arguments, IGenerics generics) {
-        var pars = parameterList.getFormalparalist();
+    static boolean parameterEquals(List<TargetType> pars, List<TargetType> arguments) {
         if (pars.size() != arguments.size())
             return false;
 
         for (var i = 0; i < pars.size(); i++) {
-            var type1 = generics.getTargetType(pars.get(i).getType());
+            var type1 = pars.get(i);
             var type2 = arguments.get(i);
             if (type1 instanceof TargetGenericType)
                 return true;
@@ -380,9 +389,15 @@ public class ASTToTargetAST {
         else return new TargetClass(input.getModifiers(), input.getClassName(), convert(input.getSuperClass(), generics.javaGenerics, compiler), javaGenerics, txGenerics, superInterfaces, constructors, staticConstructor, fields, methods);
     }
 
-    @Deprecated
     public List<MethodParameter> convert(ParameterList input) {
-        return convert(input, all.getFirst().javaGenerics);
+        var res = new ArrayList<MethodParameter>();
+        for (var i = 0; i < input.getFormalparalist().size(); i++) {
+            var param = input.getFormalparalist().get(i);
+            var pattern = (TargetPattern) convert(param, Generics.nullGenerics().javaGenerics);
+            if (pattern instanceof TargetComplexPattern) pattern = pattern.withName("__var" + i);
+            res.add(new MethodParameter(pattern));
+        }
+        return res;
     }
 
     public List<MethodParameter> convert(ParameterList input, IGenerics generics) {
@@ -701,6 +716,7 @@ public class ASTToTargetAST {
             var txMethodGenerics = collectMethodGenerics(currentClass, generics.txGenerics(), txGenerics, method);
 
             var javaSignature = new TargetMethod.Signature(javaMethodGenerics, params, returnType);
+            System.out.println(javaSignature.getDescriptor());
             var txSignature = new TargetMethod.Signature(txMethodGenerics, txParams, convert(method.getReturnType(), generics.txGenerics, compiler));
 
             signatures.add(new Signature(javaSignature, txSignature, generics));
@@ -754,7 +770,7 @@ public class ASTToTargetAST {
         for (var i = 0; i < tspec.params().size(); i++) {
             var param = tspec.params().get(i);
             if (param instanceof TargetSpecializedType fn) {
-                collectArguments(tspec, newParams);
+                collectArguments(fn, newParams);
             } else {
                 newParams.add(param);
             }

src/main/java/de/dhbwstuttgart/target/generate/StatementToTargetExpression.java

@@ -216,6 +216,10 @@ public class StatementToTargetExpression implements ASTVisitor {
         return ASTToTargetAST.findMethod(converter.compiler.getClass(className), name, args, generics, compiler);
     }
 
+    Optional<Method> findMethod(JavaClassName className, String name, List<TargetType> args, JavaTXCompiler compiler) {
+        return ASTToTargetAST.findMethod(converter.compiler.getClass(className), name, args, compiler);
+    }
+
     @Override
     public void visit(MethodCall methodCall) {
         var receiverType = converter.convert(methodCall.receiver.getType(), generics);
@@ -246,7 +250,7 @@ public class StatementToTargetExpression implements ASTVisitor {
         } else if (!isFunNType) {
             receiverClass = converter.compiler.getClass(receiverName);
             if (receiverClass == null) throw new DebugException("Class " + receiverName + " does not exist!");
-            foundMethod = findMethod(receiverName, methodCall.name, signature, generics, converter.compiler).orElseThrow();
+            foundMethod = findMethod(receiverName, methodCall.name, signature, converter.compiler).orElseThrow();
         }
 
         if (!isFunNType) {

src/main/java/de/dhbwstuttgart/typeinference/constraints/Constraint.java

@@ -85,12 +85,11 @@ public class Constraint<A extends IConstraintElement> extends HashSet<A> impleme
   }
 
 	public String toString() {
-    return super.toString();
-//            + "\nisInherited = " + isInherited
-//      + " isOveridden = " + isImplemented
-//      + " msc[" + methodSignatureConstraint.size() + "] = " + methodSignatureConstraint
-//      //" + extendsContraint: "  + (extendConstraint != null ? extendConstraint.toStringBase() : "null" )
-//      + "\n";
+    return super.toString() + "\nisInherited = " + isInherited
+      + " isOveridden = " + isImplemented
+      + " msc[" + methodSignatureConstraint.size() + "] = " + methodSignatureConstraint
+      //" + extendsContraint: "  + (extendConstraint != null ? extendConstraint.toStringBase() : "null" )
+      + "\n";
 	}
 	
 	public String toStringBase() {

src/main/java/de/dhbwstuttgart/typeinference/constraints/Pair.java

@@ -4,7 +4,6 @@ import de.dhbwstuttgart.server.packet.dataContainers.ISerializableData;
 import de.dhbwstuttgart.server.packet.dataContainers.KeyStorage;
 import de.dhbwstuttgart.server.packet.dataContainers.serialized.SerialMap;
 import de.dhbwstuttgart.typeinference.unify.UnifyContext;
-
 import java.io.Serializable;
 import java.util.HashMap;
 import java.util.Map;
@@ -14,8 +13,6 @@ import de.dhbwstuttgart.syntaxtree.type.RefTypeOrTPHOrWildcardOrGeneric;
 import de.dhbwstuttgart.syntaxtree.type.TypePlaceholder;
 import de.dhbwstuttgart.typeinference.unify.model.PairOperator;
 
-import static de.dhbwstuttgart.core.JavaTXCompiler.q;
-
 
 public class Pair implements Serializable, IConstraintElement, ISerializableData {
   public final RefTypeOrTPHOrWildcardOrGeneric TA1;
@@ -176,27 +173,5 @@ public class Pair implements Serializable, IConstraintElement, ISerializableData
     if (location != null) pair.location = SourceLoc.fromSerial(location);
     return pair;
   }
-
-    public String toDot(String color) {
-
-        return q(this.TA1.toString()) +
-                " -> " +
-                q(this.TA2.toString()) +
-                " [label=" +
-                q(this.GetOperator().toString()) +
-                ",color=" + q(color) + "]" +
-                ";\n";
-    }
-
-    public String toDot() {
-
-        return q(this.TA1.toString()) +
-                " -> " +
-                q(this.TA2.toString()) +
-                " [label=" +
-                q(this.GetOperator().toString()) +
-                "]" +
-                ";\n";
-    }
 }
 // ino.end

src/main/java/de/dhbwstuttgart/typeinference/typeAlgo/TYPE.java

@@ -35,8 +35,8 @@ public class TYPE {
         this.definedClasses = definedClasses;
     }
 
-    public ConstraintSet<Pair> getConstraints() {
-        ConstraintSet<Pair> ret = new ConstraintSet<>();
+    public ConstraintSet getConstraints() {
+        ConstraintSet ret = new ConstraintSet();
         for (ClassOrInterface cl : definedClasses) {
             Set<ClassOrInterface> allClasses = TypeUnifyTaskHelper.getPresizedHashSet(allAvailableClasses.size());
             allClasses.addAll(allAvailableClasses);
@@ -45,9 +45,9 @@ public class TYPE {
         return ret;
     }
 
-    private ConstraintSet<Pair> getConstraintsClass(ClassOrInterface cl, TypeInferenceInformation info) {
-        ConstraintSet<Pair> ret = new ConstraintSet<>();
-        ConstraintSet<Pair> methConstrains;
+    private ConstraintSet getConstraintsClass(ClassOrInterface cl, TypeInferenceInformation info) {
+        ConstraintSet ret = new ConstraintSet();
+        ConstraintSet methConstrains;
         for(Method m : cl.getMethods()){
             ret.addAll(methConstrains = getConstraintsMethod(m,info, cl));
             m.constraints.addAll(methConstrains);
@@ -86,11 +86,11 @@ public class TYPE {
         }
     */
  
-    private ConstraintSet<Pair> getConstraintsMethod(Method m, TypeInferenceInformation info, ClassOrInterface currentClass) {
-        if(m.block == null)return new ConstraintSet<Pair>(); //Abstrakte Methoden generieren keine Constraints
+    private ConstraintSet getConstraintsMethod(Method m, TypeInferenceInformation info, ClassOrInterface currentClass) {
+        if(m.block == null)return new ConstraintSet(); //Abstrakte Methoden generieren keine Constraints
         TypeInferenceBlockInformation blockInfo = new TypeInferenceBlockInformation(info.getAvailableClasses(), currentClass, m);
         TYPEStmt methodScope = new TYPEStmt(blockInfo);
-        ConstraintSet<Pair> constraintSet = new ConstraintSet<>();
+        ConstraintSet constraintSet = new ConstraintSet();
 
         if (m.name.equals("main") && Modifier.isStatic(m.modifier) && m.getParameterList().getFormalparalist().size() == 1) {
             // Add constraint for main method

src/test/java/TestComplete.java

@@ -959,6 +959,7 @@ public class TestComplete {
 
     @Test
     public void testPatternMatchingZip() throws Exception {
+        ConsoleInterface.logLevel = Logger.LogLevel.DEBUG;
         var classFiles = generateClassFiles(createClassLoader(), "PatternMatching.jav");
         var clazz = classFiles.get("PatternMatching");
         var instance = clazz.getDeclaredConstructor().newInstance();
@@ -966,7 +967,6 @@ public class TestComplete {
 
     @Test
     public void testPatternMatchingZipJava() throws Exception {
-        ConsoleInterface.logLevel = Logger.LogLevel.DEBUG;
         var classFiles = generateClassFiles(createClassLoader(), false, "PatternMatchingJava.jav", "PatternMatchingJava2.jav");
         var clazz = classFiles.get("PatternMatchingJava");
         var instance = clazz.getDeclaredConstructor().newInstance();
@@ -1536,6 +1536,13 @@ public class TestComplete {
         // TODO This logs output that we should validate
     }
 
+    @Test
+    public void testBug389() throws Exception {
+        var classFiles = generateClassFiles(createClassLoader(), false, "Bug389.jav", "Bug389Main.jav");
+        var clazz = classFiles.get("Bug389Main");
+        clazz.getDeclaredMethod("main", List.class).invoke(null, List.of());
+    }
+
     @Test
     public void testBug390() throws Exception {
         var classFiles = generateClassFiles(createClassLoader(), "Bug390.jav");