Raw Types in Java-TX #336

New Issue

Closed

opened 2024-05-16 11:05:09 +00:00 by i21023 · 2 comments

i21023 commented 2024-05-16 11:05:09 +00:00

Collaborator

Copy Link

Raw Types funktionieren in Java-TX aktuell nicht wirklich, werden aber z.B. in der TYPE und TYPEStmt Klasse im Zusammenhang mit ConstraintSet im Java-TX Compiler sehr ausgiebig verwendet. Die Frage ist nun wahrscheinlich eher, ob man raw types in Java-TX unterstützen kann/möchte, oder man ggf. den Code vom Compiler refactored und generische Typen korrekt verwendet.

Beispiel:

MySetWrapper.java

import java.util.HashSet;
import java.util.Set;

public class MySetWrapper<A> {
    Set<A> set = new HashSet<>();

    public void addAll(MySetWrapper other) {
        set.addAll(other.set);
    }
}

Foo.java

public class Foo{
    void foo(){
        MySetWrapper mySetWrapper = new MySetWrapper();
        MySetWrapper mySetWrapper2 = new MySetWrapper();
        mySetWrapper.addAll(mySetWrapper2);
    }
}

javac Foo.java compiliert, wenn auch mit warnings.

Das gleiche mit dem Java-TX-Compiler ergibt unaufgelöste Constraints.

Foo.jav

public class Foo{
    foo(){
        var mySetWrapper = new MySetWrapper();
        var mySetWrapper2 = new MySetWrapper();
        mySetWrapper.addAll(mySetWrapper2);
    }
}

Aufruf mit:
javac MySetWrapper.java
java -jar JavaTXCompiler.jar Foo.java

führt zu:

Exception in thread "main" de.dhbwstuttgart.exceptions.TypeinferenceException: Unresolved constraints: [[(? super MySetWrapper<gen_a> <. MySetWrapper, )@5 in Foo.java, (? super MySetWrapper<gen_a> <. MySetWrapper, )@5 in Foo.java], [(? extends MySetWrapper<YL> =. MySetWrapper<gen_h>, )@3 in Foo.java, (java.lang.Object <. MySetWrapper, )@5 in Foo.java], [(? extends MySetWrapper<YL> =. MySetWrapper<gen_h>, )@3 in Foo.java, (MySetWrapper<gen_f> <. MySetWrapper, )@5 in Foo.java], [(? super MySetWrapper<gen_hj> <. MySetWrapper, )@5 in Foo.java], [(MySetWrapper<YL> =. ? super java.lang.Object, )@3 in Foo.java, (MySetWrapper<gen_k> <. MySetWrapper, )@5 in Foo.java], [(MySetWrapper<gen_hs> <. MySetWrapper, )@5 in Foo.java], [(? extends MySetWrapper<YL> =. ? super MySetWrapper<gen_v>, )@3 in Foo.java, (MySetWrapper<gen_hr> <. MySetWrapper, )@5 in Foo.java], [(? extends MySetWrapper<YL> =. MySetWrapper<gen_h>, )@3 in Foo.java], [(? extends MySetWrapper<YL> =. ? super MySetWrapper<gen_v>, )@3 in Foo.java, (? super java.lang.Object <. MySetWrapper, )@5 in Foo.java], [(MySetWrapper<YL> =. ? super java.lang.Object, )@3 in Foo.java, (? super java.lang.Object <. MySetWrapper, )@5 in Foo.java], [(MySetWrapper<gen_f> <. MySetWrapper, )@5 in Foo.java], [(? extends MySetWrapper<YL> =. java.lang.Object, )@3 in Foo.java, (java.lang.Object <. MySetWrapper, )@5 in Foo.java], [(? extends MySetWrapper<YL> =. ? super MySetWrapper<gen_v>, )@3 in Foo.java, (? extends MySetWrapper<YL> =. ? super MySetWrapper<gen_v>, )@3 in Foo.java, (? super MySetWrapper<gen_r> <. MySetWrapper, )@5 in Foo.java, (MySetWrapper<gen_hr> <. MySetWrapper, )@5 in Foo.java, (? super java.lang.Object <. MySetWrapper, )@5 in Foo.java, (java.lang.Object <. MySetWrapper, )@5 in Foo.java], [(? super MySetWrapper<gen_b> <. MySetWrapper, )@5 in Foo.java, (? super MySetWrapper<gen_b> <. MySetWrapper, )@5 in Foo.java], [(MySetWrapper<gen_hr> <. MySetWrapper, )@5 in Foo.java], [(MySetWrapper<gen_hs> <. MySetWrapper, )@5 in Foo.java, (MySetWrapper<gen_hs> <. MySetWrapper, )@5 in Foo.java], [(MySetWrapper<YL> =. ? super java.lang.Object, )@3 in Foo.java, (MySetWrapper<YL> =. ? super java.lang.Object, )@3 in Foo.java, (MySetWrapper<YL> =. ? super java.lang.Object, )@3 in Foo.java, (MySetWrapper<YL> =. ? super java.lang.Object, )@3 in Foo.java, (? super java.lang.Object <. MySetWrapper, )@5 in Foo.java, (java.lang.Object <. MySetWrapper, )@5 in Foo.java, (MySetWrapper<gen_k> <. MySetWrapper, )@5 in Foo.java, (? super MySetWrapper<gen_hj> <. MySetWrapper, )@5 in Foo.java], [(? super java.lang.Object <. MySetWrapper, )@5 in Foo.java], [(? super java.lang.Object <. MySetWrapper, )@5 in Foo.java], [(MySetWrapper<gen_k> <. MySetWrapper, )@5 in Foo.java], [(? extends MySetWrapper<YL> =. ? super MySetWrapper<gen_v>, )@3 in Foo.java, (java.lang.Object <. MySetWrapper, )@5 in Foo.java], [(? extends MySetWrapper<YL> =. java.lang.Object, )@3 in Foo.java, (? super java.lang.Object <. MySetWrapper, )@5 in Foo.java], [(? super MySetWrapper<gen_a> <. MySetWrapper, )@5 in Foo.java, (? super MySetWrapper<gen_a> <. MySetWrapper, )@5 in Foo.java, (MySetWrapper<gen_hs> <. MySetWrapper, )@5 in Foo.java, (MySetWrapper<gen_hs> <. MySetWrapper, )@5 in Foo.java, (? extends MySetWrapper<YL> =. java.lang.Object, )@3 in Foo.java, (? extends MySetWrapper<YL> =. java.lang.Object, )@3 in Foo.java, (? super java.lang.Object <. MySetWrapper, )@5 in Foo.java, (java.lang.Object <. MySetWrapper, )@5 in Foo.java], [(? extends MySetWrapper<YL> =. ? super MySetWrapper<gen_v>, )@3 in Foo.java, (? super MySetWrapper<gen_r> <. MySetWrapper, )@5 in Foo.java], [(MySetWrapper<YL> =. ? super java.lang.Object, )@3 in Foo.java, (java.lang.Object <. MySetWrapper, )@5 in Foo.java], [(java.lang.Object <. MySetWrapper, )@5 in Foo.java], [(java.lang.Object <. MySetWrapper, )@5 in Foo.java], [(? super MySetWrapper<gen_b> <. MySetWrapper, )@5 in Foo.java, (? super MySetWrapper<gen_b> <. MySetWrapper, )@5 in Foo.java, (? extends MySetWrapper<YL> =. MySetWrapper<gen_h>, )@3 in Foo.java, (? extends MySetWrapper<YL> =. MySetWrapper<gen_h>, )@3 in Foo.java, (? super java.lang.Object <. MySetWrapper, )@5 in Foo.java, (java.lang.Object <. MySetWrapper, )@5 in Foo.java, (MySetWrapper<gen_f> <. MySetWrapper, )@5 in Foo.java], [(? super java.lang.Object <. MySetWrapper, )@5 in Foo.java, (? extends MySetWrapper<YL> =. MySetWrapper<gen_h>, )@3 in Foo.java]]
        at de.dhbwstuttgart.typeinference.unify.TypeUnifyTask.compute(TypeUnifyTask.java:275)
        at de.dhbwstuttgart.typeinference.unify.TypeUnifyTask.compute(TypeUnifyTask.java:63)
        at java.base/java.util.concurrent.RecursiveTask.exec(RecursiveTask.java:110)
        at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
        at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312)
        at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843)
        at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808)
        at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)

Raw Types funktionieren in Java-TX aktuell nicht wirklich, werden aber z.B. in der TYPE und TYPEStmt Klasse im Zusammenhang mit ConstraintSet<A> im Java-TX Compiler sehr ausgiebig verwendet. Die Frage ist nun wahrscheinlich eher, ob man raw types in Java-TX unterstützen kann/möchte, oder man ggf. den Code vom Compiler refactored und generische Typen korrekt verwendet. ### Beispiel: MySetWrapper.java ```java import java.util.HashSet; import java.util.Set; public class MySetWrapper<A> { Set<A> set = new HashSet<>(); public void addAll(MySetWrapper other) { set.addAll(other.set); } } ``` Foo.java ```java public class Foo{ void foo(){ MySetWrapper mySetWrapper = new MySetWrapper(); MySetWrapper mySetWrapper2 = new MySetWrapper(); mySetWrapper.addAll(mySetWrapper2); } } ``` `javac Foo.java` compiliert, wenn auch mit warnings. Das gleiche mit dem Java-TX-Compiler ergibt unaufgelöste Constraints. Foo.jav ```java public class Foo{ foo(){ var mySetWrapper = new MySetWrapper(); var mySetWrapper2 = new MySetWrapper(); mySetWrapper.addAll(mySetWrapper2); } } ``` Aufruf mit: `javac MySetWrapper.java` `java -jar JavaTXCompiler.jar Foo.java` führt zu: ``` Exception in thread "main" de.dhbwstuttgart.exceptions.TypeinferenceException: Unresolved constraints: [[(? super MySetWrapper<gen_a> <. MySetWrapper, )@5 in Foo.java, (? super MySetWrapper<gen_a> <. MySetWrapper, )@5 in Foo.java], [(? extends MySetWrapper<YL> =. MySetWrapper<gen_h>, )@3 in Foo.java, (java.lang.Object <. MySetWrapper, )@5 in Foo.java], [(? extends MySetWrapper<YL> =. MySetWrapper<gen_h>, )@3 in Foo.java, (MySetWrapper<gen_f> <. MySetWrapper, )@5 in Foo.java], [(? super MySetWrapper<gen_hj> <. MySetWrapper, )@5 in Foo.java], [(MySetWrapper<YL> =. ? super java.lang.Object, )@3 in Foo.java, (MySetWrapper<gen_k> <. MySetWrapper, )@5 in Foo.java], [(MySetWrapper<gen_hs> <. MySetWrapper, )@5 in Foo.java], [(? extends MySetWrapper<YL> =. ? super MySetWrapper<gen_v>, )@3 in Foo.java, (MySetWrapper<gen_hr> <. MySetWrapper, )@5 in Foo.java], [(? extends MySetWrapper<YL> =. MySetWrapper<gen_h>, )@3 in Foo.java], [(? extends MySetWrapper<YL> =. ? super MySetWrapper<gen_v>, )@3 in Foo.java, (? super java.lang.Object <. MySetWrapper, )@5 in Foo.java], [(MySetWrapper<YL> =. ? super java.lang.Object, )@3 in Foo.java, (? super java.lang.Object <. MySetWrapper, )@5 in Foo.java], [(MySetWrapper<gen_f> <. MySetWrapper, )@5 in Foo.java], [(? extends MySetWrapper<YL> =. java.lang.Object, )@3 in Foo.java, (java.lang.Object <. MySetWrapper, )@5 in Foo.java], [(? extends MySetWrapper<YL> =. ? super MySetWrapper<gen_v>, )@3 in Foo.java, (? extends MySetWrapper<YL> =. ? super MySetWrapper<gen_v>, )@3 in Foo.java, (? super MySetWrapper<gen_r> <. MySetWrapper, )@5 in Foo.java, (MySetWrapper<gen_hr> <. MySetWrapper, )@5 in Foo.java, (? super java.lang.Object <. MySetWrapper, )@5 in Foo.java, (java.lang.Object <. MySetWrapper, )@5 in Foo.java], [(? super MySetWrapper<gen_b> <. MySetWrapper, )@5 in Foo.java, (? super MySetWrapper<gen_b> <. MySetWrapper, )@5 in Foo.java], [(MySetWrapper<gen_hr> <. MySetWrapper, )@5 in Foo.java], [(MySetWrapper<gen_hs> <. MySetWrapper, )@5 in Foo.java, (MySetWrapper<gen_hs> <. MySetWrapper, )@5 in Foo.java], [(MySetWrapper<YL> =. ? super java.lang.Object, )@3 in Foo.java, (MySetWrapper<YL> =. ? super java.lang.Object, )@3 in Foo.java, (MySetWrapper<YL> =. ? super java.lang.Object, )@3 in Foo.java, (MySetWrapper<YL> =. ? super java.lang.Object, )@3 in Foo.java, (? super java.lang.Object <. MySetWrapper, )@5 in Foo.java, (java.lang.Object <. MySetWrapper, )@5 in Foo.java, (MySetWrapper<gen_k> <. MySetWrapper, )@5 in Foo.java, (? super MySetWrapper<gen_hj> <. MySetWrapper, )@5 in Foo.java], [(? super java.lang.Object <. MySetWrapper, )@5 in Foo.java], [(? super java.lang.Object <. MySetWrapper, )@5 in Foo.java], [(MySetWrapper<gen_k> <. MySetWrapper, )@5 in Foo.java], [(? extends MySetWrapper<YL> =. ? super MySetWrapper<gen_v>, )@3 in Foo.java, (java.lang.Object <. MySetWrapper, )@5 in Foo.java], [(? extends MySetWrapper<YL> =. java.lang.Object, )@3 in Foo.java, (? super java.lang.Object <. MySetWrapper, )@5 in Foo.java], [(? super MySetWrapper<gen_a> <. MySetWrapper, )@5 in Foo.java, (? super MySetWrapper<gen_a> <. MySetWrapper, )@5 in Foo.java, (MySetWrapper<gen_hs> <. MySetWrapper, )@5 in Foo.java, (MySetWrapper<gen_hs> <. MySetWrapper, )@5 in Foo.java, (? extends MySetWrapper<YL> =. java.lang.Object, )@3 in Foo.java, (? extends MySetWrapper<YL> =. java.lang.Object, )@3 in Foo.java, (? super java.lang.Object <. MySetWrapper, )@5 in Foo.java, (java.lang.Object <. MySetWrapper, )@5 in Foo.java], [(? extends MySetWrapper<YL> =. ? super MySetWrapper<gen_v>, )@3 in Foo.java, (? super MySetWrapper<gen_r> <. MySetWrapper, )@5 in Foo.java], [(MySetWrapper<YL> =. ? super java.lang.Object, )@3 in Foo.java, (java.lang.Object <. MySetWrapper, )@5 in Foo.java], [(java.lang.Object <. MySetWrapper, )@5 in Foo.java], [(java.lang.Object <. MySetWrapper, )@5 in Foo.java], [(? super MySetWrapper<gen_b> <. MySetWrapper, )@5 in Foo.java, (? super MySetWrapper<gen_b> <. MySetWrapper, )@5 in Foo.java, (? extends MySetWrapper<YL> =. MySetWrapper<gen_h>, )@3 in Foo.java, (? extends MySetWrapper<YL> =. MySetWrapper<gen_h>, )@3 in Foo.java, (? super java.lang.Object <. MySetWrapper, )@5 in Foo.java, (java.lang.Object <. MySetWrapper, )@5 in Foo.java, (MySetWrapper<gen_f> <. MySetWrapper, )@5 in Foo.java], [(? super java.lang.Object <. MySetWrapper, )@5 in Foo.java, (? extends MySetWrapper<YL> =. MySetWrapper<gen_h>, )@3 in Foo.java]] at de.dhbwstuttgart.typeinference.unify.TypeUnifyTask.compute(TypeUnifyTask.java:275) at de.dhbwstuttgart.typeinference.unify.TypeUnifyTask.compute(TypeUnifyTask.java:63) at java.base/java.util.concurrent.RecursiveTask.exec(RecursiveTask.java:110) at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387) at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312) at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843) at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808) at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188) ```

Archiv.zip

20 MiB

dholle commented 2024-06-04 14:01:58 +00:00

Owner

Copy Link

Man könnte vielleicht Object inferieren. Ich bin allerdings der Meinung, dass man bei einer neuen Sprache nicht unbedingt die Fehler von Java übernehmen sollte. Wie siehst du das, @pl ?

Man könnte vielleicht `Object` inferieren. Ich bin allerdings der Meinung, dass man bei einer neuen Sprache nicht unbedingt die Fehler von Java übernehmen sollte. Wie siehst du das, @pl ?

pl commented 2024-06-05 11:48:57 +00:00

Owner

Copy Link

In Java-TX sollen keine Raw-Types implementiert werden.

In Java-TX sollen keine Raw-Types implementiert werden.

dholle closed this issue 2024-06-24 08:30:15 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

targetBytecode

patternMatching

newConstraints

aspGen

bigRefactoring

unif23NoOptParallel

unif23NoOptParallel_Lehmann

fixPlugin

parseSignature

unif23Full

unif23

gradle

astRecordRefactoring

refactorToAPIs

bigCleanup

typeErasure

inferWildcards

bytecodeGenericsSecond

generateTestConstraints

refactoringUnify

bigRefactoringUnifyComment

bytecodeGenerics

refactoringConstraintSet

refactoring2020

addPackages

simplifyRes

classloader

bytecode2

unify-test

bcGenerics

plugin

unify-PartialOrderSet

sat

unifyOptimierung

UnifyDependentSubstitutions

strucTypesNew

UnifyAllSolutions

strucTypesTemp

parser

strucTypesVollmer

ohneMaven

master

antlr2

martin

antlr

strucTypes_dev_PL

strucTypes_dev2

refactoring

strucTypes

bcel

intellij

bytecode

unify

unifyStable

unifyDev

classfile

No results found.

Labels

Clear labels   

Codegen

  

confirmed

  

duplicate

  

Eclipse-Plugin

  

Feature Request

  

generics

  

in progress

  

invalid

  

JavaCompilerCore

  

needs info

  

Parser

  

Trash

  

Type

  

Unify

  

won't fix

  

works for me

No Label

Codegen

confirmed

duplicate

Eclipse-Plugin

Feature Request

generics

in progress

invalid

JavaCompilerCore

needs info

Parser

Trash

Type

Unify

won't fix

works for me

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

3 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: JavaTX/JavaCompilerCore#336

No description provided.