diff --git a/src/hotspot/cpu/x86/c2_intelJccErratum_x86.cpp b/src/hotspot/cpu/x86/c2_intelJccErratum_x86.cpp index 349ca325fa9..6cfa2ce1a31 100644 --- a/src/hotspot/cpu/x86/c2_intelJccErratum_x86.cpp +++ b/src/hotspot/cpu/x86/c2_intelJccErratum_x86.cpp @@ -100,7 +100,7 @@ int IntelJccErratum::compute_padding(uintptr_t current_offset, const MachNode* m if (index_in_block < block->number_of_nodes() - 1) { Node* next = block->get_node(index_in_block + 1); if (next->is_Mach() && (next->as_Mach()->flags() & Node::PD::Flag_intel_jcc_erratum)) { - jcc_size += mach->size(regalloc); + jcc_size += next->size(regalloc); } } if (jcc_size > largest_jcc_size()) { diff --git a/src/hotspot/share/opto/compile.cpp b/src/hotspot/share/opto/compile.cpp index 28fd50840cb..6f9395eb72b 100644 --- a/src/hotspot/share/opto/compile.cpp +++ b/src/hotspot/share/opto/compile.cpp @@ -2975,10 +2975,9 @@ void Compile::Code_Gen() { output.Output(); if (failing()) return; output.install(); + print_method(PHASE_FINAL_CODE, 1); // Compile::_output is not null here } - print_method(PHASE_FINAL_CODE, 1); - // He's dead, Jim. _cfg = (PhaseCFG*)((intptr_t)0xdeadbeef); _regalloc = (PhaseChaitin*)((intptr_t)0xdeadbeef); diff --git a/test/hotspot/jtreg/compiler/c2/irTests/TestPadding.java b/test/hotspot/jtreg/compiler/c2/irTests/TestPadding.java new file mode 100644 index 00000000000..25225e86b28 --- /dev/null +++ b/test/hotspot/jtreg/compiler/c2/irTests/TestPadding.java @@ -0,0 +1,87 @@ +/* + * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + * + */ + +package compiler.c2.irTests; + +import compiler.lib.ir_framework.*; + +/* + * @test + * @bug 8309978 + * @summary [x64] Fix useless padding + * @library /test/lib / + * @requires vm.compiler2.enabled + * @requires (os.simpleArch == "x64") + * @run driver compiler.c2.irTests.TestPadding + */ + +public class TestPadding { + public static void main(String[] args) { + TestFramework.runWithFlags("-XX:+IntelJccErratumMitigation"); + } + + @Run(test = "test") + public static void test_runner() { + test(42); + tpf.b1++; // to take both branches in test() + } + + @Test + @IR(counts = { IRNode.NOP, "1" }) + static int test(int i) { + TestPadding tp = tpf; + if (tp.b1 > 42) { // Big 'cmpb' instruction at offset 0x30 + tp.i1 = i; + } + return i; + } + + static TestPadding t1; + static TestPadding t2; + static TestPadding t3; + static TestPadding t4; + + static TestPadding tpf = new TestPadding(); // Static field offset > 128 + + int i1; + + long l1; + long l2; + long l3; + long l4; + long l5; + long l6; + long l7; + long l8; + long l9; + long l10; + long l11; + long l12; + long l13; + long l14; + long l15; + long l16; + + byte b1 = 1; // Field offset > 128 +} diff --git a/test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java b/test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java index 2422d96cdd6..352ae453144 100644 --- a/test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java +++ b/test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java @@ -809,6 +809,11 @@ public class IRNode { beforeMatchingNameRegex(NEG_V, "NegV(F|D)"); } + public static final String NOP = PREFIX + "NOP" + POSTFIX; + static { + machOnlyNameRegex(NOP, "Nop"); + } + public static final String NULL_ASSERT_TRAP = PREFIX + "NULL_ASSERT_TRAP" + POSTFIX; static { trapNodes(NULL_ASSERT_TRAP,"null_assert");