8065986: Compiler fails to NullPointerException when calling super with Object<>()
Missing POLY kind selector on recursive constructor calls with poly arguments Reviewed-by: vromero
This commit is contained in:
Maurizio Cimadamore
parent
634c33938c
commit
02df6a4564
@ -629,19 +629,19 @@ public class Attr extends JCTree.Visitor {
|
||||
|
||||
/** Attribute the arguments in a method call, returning the method kind.
|
||||
*/
|
||||
KindSelector attribArgs(List<JCExpression> trees, Env<AttrContext> env, ListBuffer<Type> argtypes) {
|
||||
boolean polykind = false;
|
||||
KindSelector attribArgs(KindSelector initialKind, List<JCExpression> trees, Env<AttrContext> env, ListBuffer<Type> argtypes) {
|
||||
KindSelector kind = initialKind;
|
||||
for (JCExpression arg : trees) {
|
||||
Type argtype;
|
||||
if (allowPoly && deferredAttr.isDeferred(env, arg)) {
|
||||
argtype = deferredAttr.new DeferredType(arg, env);
|
||||
polykind = true;
|
||||
kind = KindSelector.of(KindSelector.POLY, kind);
|
||||
} else {
|
||||
argtype = chk.checkNonVoid(arg, attribTree(arg, env, unknownAnyPolyInfo));
|
||||
}
|
||||
argtypes.append(argtype);
|
||||
}
|
||||
return polykind ? KindSelector.VAL_POLY : KindSelector.VAL;
|
||||
return kind;
|
||||
}
|
||||
|
||||
/** Attribute a type argument list, returning a list of types.
|
||||
@ -1704,7 +1704,7 @@ public class Attr extends JCTree.Visitor {
|
||||
localEnv.info.isSelfCall = true;
|
||||
|
||||
// Attribute arguments, yielding list of argument types.
|
||||
attribArgs(tree.args, localEnv, argtypesBuf);
|
||||
KindSelector kind = attribArgs(KindSelector.MTH, tree.args, localEnv, argtypesBuf);
|
||||
argtypes = argtypesBuf.toList();
|
||||
typeargtypes = attribTypes(tree.typeargs, localEnv);
|
||||
|
||||
@ -1770,7 +1770,7 @@ public class Attr extends JCTree.Visitor {
|
||||
// (this will also set the tree's type)
|
||||
Type mpt = newMethodTemplate(resultInfo.pt, argtypes, typeargtypes);
|
||||
checkId(tree.meth, site, sym, localEnv,
|
||||
new ResultInfo(KindSelector.MTH, mpt));
|
||||
new ResultInfo(kind, mpt));
|
||||
}
|
||||
// Otherwise, `site' is an error type and we do nothing
|
||||
}
|
||||
@ -1778,7 +1778,7 @@ public class Attr extends JCTree.Visitor {
|
||||
} else {
|
||||
// Otherwise, we are seeing a regular method call.
|
||||
// Attribute the arguments, yielding list of argument types, ...
|
||||
KindSelector kind = attribArgs(tree.args, localEnv, argtypesBuf);
|
||||
KindSelector kind = attribArgs(KindSelector.VAL, tree.args, localEnv, argtypesBuf);
|
||||
argtypes = argtypesBuf.toList();
|
||||
typeargtypes = attribAnyTypes(tree.typeargs, localEnv);
|
||||
|
||||
@ -1958,7 +1958,7 @@ public class Attr extends JCTree.Visitor {
|
||||
// Attribute constructor arguments.
|
||||
ListBuffer<Type> argtypesBuf = new ListBuffer<>();
|
||||
final KindSelector pkind =
|
||||
attribArgs(tree.args, localEnv, argtypesBuf);
|
||||
attribArgs(KindSelector.VAL, tree.args, localEnv, argtypesBuf);
|
||||
List<Type> argtypes = argtypesBuf.toList();
|
||||
List<Type> typeargtypes = attribTypes(tree.typeargs, localEnv);
|
||||
|
||||
|
||||
@ -0,0 +1,33 @@
|
||||
/*
|
||||
* @test /nodynamiccopyright/
|
||||
* @bug 8065986
|
||||
*
|
||||
* @summary Compiler fails to NullPointerException when calling super with Object<>()
|
||||
* @compile/fail/ref=T8065986a.out T8065986a.java -XDrawDiagnostics
|
||||
*
|
||||
*/
|
||||
import java.util.ArrayList;
|
||||
|
||||
class T8065986a {
|
||||
T8065986a() {
|
||||
super(new Object<>());
|
||||
}
|
||||
|
||||
T8065986a(boolean b) {
|
||||
super(new ArrayList<>());
|
||||
}
|
||||
|
||||
T8065986a(boolean b1, boolean b2) {
|
||||
super(()->{});
|
||||
}
|
||||
|
||||
T8065986a(boolean b1, boolean b2, boolean b3) {
|
||||
super(T8065986a::m);
|
||||
}
|
||||
|
||||
T8065986a(boolean cond, Object o1, Object o2) {
|
||||
super(cond ? o1 : o2);
|
||||
}
|
||||
|
||||
static void m() { }
|
||||
}
|
||||
@ -0,0 +1,6 @@
|
||||
T8065986a.java:13:25: compiler.err.cant.apply.diamond.1: java.lang.Object, (compiler.misc.diamond.non.generic: java.lang.Object)
|
||||
T8065986a.java:17:9: compiler.err.cant.apply.symbol: kindname.constructor, Object, compiler.misc.no.args, java.util.ArrayList<java.lang.Object>, kindname.class, java.lang.Object, (compiler.misc.arg.length.mismatch)
|
||||
T8065986a.java:21:9: compiler.err.cant.apply.symbol: kindname.constructor, Object, compiler.misc.no.args, @438, kindname.class, java.lang.Object, (compiler.misc.arg.length.mismatch)
|
||||
T8065986a.java:25:9: compiler.err.cant.apply.symbol: kindname.constructor, Object, compiler.misc.no.args, @520, kindname.class, java.lang.Object, (compiler.misc.arg.length.mismatch)
|
||||
T8065986a.java:29:9: compiler.err.cant.apply.symbol: kindname.constructor, Object, compiler.misc.no.args, @608, kindname.class, java.lang.Object, (compiler.misc.arg.length.mismatch)
|
||||
5 errors
|
||||
@ -0,0 +1,33 @@
|
||||
/*
|
||||
* @test /nodynamiccopyright/
|
||||
* @bug 8065986
|
||||
*
|
||||
* @summary Compiler fails to NullPointerException when calling super with Object<>()
|
||||
* @compile/fail/ref=T8065986b.out T8065986b.java -XDrawDiagnostics
|
||||
*
|
||||
*/
|
||||
import java.util.ArrayList;
|
||||
|
||||
class T8065986b {
|
||||
T8065986b() {
|
||||
this(new Object<>());
|
||||
}
|
||||
|
||||
T8065986b(boolean b) {
|
||||
this(new ArrayList<>());
|
||||
}
|
||||
|
||||
T8065986b(boolean b1, boolean b2) {
|
||||
this(()->{});
|
||||
}
|
||||
|
||||
T8065986b(boolean b1, boolean b2, boolean b3) {
|
||||
this(T8065986b::m);
|
||||
}
|
||||
|
||||
T8065986b(boolean cond, Object o1, Object o2) {
|
||||
this(cond ? o1 : o2);
|
||||
}
|
||||
|
||||
static void m() { }
|
||||
}
|
||||
@ -0,0 +1,6 @@
|
||||
T8065986b.java:13:24: compiler.err.cant.apply.diamond.1: java.lang.Object, (compiler.misc.diamond.non.generic: java.lang.Object)
|
||||
T8065986b.java:17:9: compiler.err.cant.apply.symbols: kindname.constructor, T8065986b, java.util.ArrayList<java.lang.Object>,{(compiler.misc.inapplicable.method: kindname.constructor, T8065986b, T8065986b(), (compiler.misc.arg.length.mismatch)),(compiler.misc.inapplicable.method: kindname.constructor, T8065986b, T8065986b(boolean), (compiler.misc.no.conforming.assignment.exists: (compiler.misc.cant.apply.diamond.1: (compiler.misc.diamond: java.util.ArrayList), (compiler.misc.infer.no.conforming.instance.exists: E, java.util.ArrayList<E>, boolean)))),(compiler.misc.inapplicable.method: kindname.constructor, T8065986b, T8065986b(boolean,boolean), (compiler.misc.arg.length.mismatch)),(compiler.misc.inapplicable.method: kindname.constructor, T8065986b, T8065986b(boolean,boolean,boolean), (compiler.misc.arg.length.mismatch)),(compiler.misc.inapplicable.method: kindname.constructor, T8065986b, T8065986b(boolean,java.lang.Object,java.lang.Object), (compiler.misc.arg.length.mismatch))}
|
||||
T8065986b.java:21:9: compiler.err.cant.apply.symbols: kindname.constructor, T8065986b, @435,{(compiler.misc.inapplicable.method: kindname.constructor, T8065986b, T8065986b(), (compiler.misc.arg.length.mismatch)),(compiler.misc.inapplicable.method: kindname.constructor, T8065986b, T8065986b(boolean), (compiler.misc.no.conforming.assignment.exists: (compiler.misc.not.a.functional.intf: boolean))),(compiler.misc.inapplicable.method: kindname.constructor, T8065986b, T8065986b(boolean,boolean), (compiler.misc.arg.length.mismatch)),(compiler.misc.inapplicable.method: kindname.constructor, T8065986b, T8065986b(boolean,boolean,boolean), (compiler.misc.arg.length.mismatch)),(compiler.misc.inapplicable.method: kindname.constructor, T8065986b, T8065986b(boolean,java.lang.Object,java.lang.Object), (compiler.misc.arg.length.mismatch))}
|
||||
T8065986b.java:25:9: compiler.err.cant.apply.symbols: kindname.constructor, T8065986b, @516,{(compiler.misc.inapplicable.method: kindname.constructor, T8065986b, T8065986b(), (compiler.misc.arg.length.mismatch)),(compiler.misc.inapplicable.method: kindname.constructor, T8065986b, T8065986b(boolean), (compiler.misc.no.conforming.assignment.exists: (compiler.misc.not.a.functional.intf: boolean))),(compiler.misc.inapplicable.method: kindname.constructor, T8065986b, T8065986b(boolean,boolean), (compiler.misc.arg.length.mismatch)),(compiler.misc.inapplicable.method: kindname.constructor, T8065986b, T8065986b(boolean,boolean,boolean), (compiler.misc.arg.length.mismatch)),(compiler.misc.inapplicable.method: kindname.constructor, T8065986b, T8065986b(boolean,java.lang.Object,java.lang.Object), (compiler.misc.arg.length.mismatch))}
|
||||
T8065986b.java:29:9: compiler.err.cant.apply.symbols: kindname.constructor, T8065986b, @603,{(compiler.misc.inapplicable.method: kindname.constructor, T8065986b, T8065986b(), (compiler.misc.arg.length.mismatch)),(compiler.misc.inapplicable.method: kindname.constructor, T8065986b, T8065986b(boolean), (compiler.misc.no.conforming.assignment.exists: (compiler.misc.incompatible.type.in.conditional: (compiler.misc.inconvertible.types: java.lang.Object, boolean)))),(compiler.misc.inapplicable.method: kindname.constructor, T8065986b, T8065986b(boolean,boolean), (compiler.misc.arg.length.mismatch)),(compiler.misc.inapplicable.method: kindname.constructor, T8065986b, T8065986b(boolean,boolean,boolean), (compiler.misc.arg.length.mismatch)),(compiler.misc.inapplicable.method: kindname.constructor, T8065986b, T8065986b(boolean,java.lang.Object,java.lang.Object), (compiler.misc.arg.length.mismatch))}
|
||||
5 errors
|
||||
Loading…
Reference in New Issue
Block a user