stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8076625: IndexOutOfBoundsException in HeapByteBufferTest.java

Browse Source 
Use Utils::getRandomInstance and nextInt to get reproducable and limited random values.

Reviewed-by: kvn, vlivanov
This commit is contained in:
Tobias Hartmann 2015-04-13 07:00:47 +02:00
parent 1b5090da9e
commit 03116a7e0e
1 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
hotspot/test/compiler/intrinsics/unsafe/HeapByteBufferTest.java
View File

@ -23,18 +23,19 @@
// //
// //
import com.oracle.java.testlibrary.Utils;
import static java.lang.Math.abs; import static java.lang.Math.abs;
import java.nio.ByteBuffer; import java.nio.ByteBuffer;
import java.nio.ByteOrder; import java.nio.ByteOrder;
import static java.nio.ByteOrder.BIG_ENDIAN; import static java.nio.ByteOrder.BIG_ENDIAN;
import static java.nio.ByteOrder.LITTLE_ENDIAN; import static java.nio.ByteOrder.LITTLE_ENDIAN;
import java.util.SplittableRandom; import java.util.Random;
import java.util.Arrays; import java.util.Arrays;
/** /**
* @test * @test
* @bug 8026049 * @bug 8026049
* @library /testlibrary
* @run main/othervm -XX:+UnlockDiagnosticVMOptions -XX:-UseUnalignedAccesses HeapByteBufferTest * @run main/othervm -XX:+UnlockDiagnosticVMOptions -XX:-UseUnalignedAccesses HeapByteBufferTest
* @run main/othervm HeapByteBufferTest * @run main/othervm HeapByteBufferTest
* @summary Verify that byte buffers are correctly accessed. * @summary Verify that byte buffers are correctly accessed.
@ -242,11 +243,11 @@ class MyByteBuffer {
public class HeapByteBufferTest implements Runnable { public class HeapByteBufferTest implements Runnable {
SplittableRandom random = new SplittableRandom(); Random random = Utils.getRandomInstance();
MyByteBuffer data = MyByteBuffer.wrap(new byte[1024]); MyByteBuffer data = MyByteBuffer.wrap(new byte[1024]);
int randomOffset(SplittableRandom r, MyByteBuffer buf, int size) { int randomOffset(Random r, MyByteBuffer buf, int size) {
return abs(r.nextInt()) % (buf.capacity() - size); return r.nextInt(buf.capacity() - size);
} }
long iterations; long iterations;
@ -259,7 +260,7 @@ public class HeapByteBufferTest implements Runnable {
// random data, XORing it as we go. We can detect writes in the // random data, XORing it as we go. We can detect writes in the
// wrong place, writes which are too long or too short, and reads // wrong place, writes which are too long or too short, and reads
// or writes of the wrong data, // or writes of the wrong data,
void step(SplittableRandom r) { void step(Random r) {
data.order((r.nextInt() & 1) != 0 ? BIG_ENDIAN : LITTLE_ENDIAN); data.order((r.nextInt() & 1) != 0 ? BIG_ENDIAN : LITTLE_ENDIAN);
data.rewind(); data.rewind();
@ -296,11 +297,11 @@ public class HeapByteBufferTest implements Runnable {
data.putInt(offset, data.getInt(offset) ^ random.nextInt()); data.putInt(offset, data.getInt(offset) ^ random.nextInt());
} }
for (int i = 0; i < 100; i++) { for (int i = 0; i < 100; i++) {
int offset = randomOffset(r, data, 4); int offset = randomOffset(r, data, 2);
data.putShort(offset, (short)(data.getShort(offset) ^ random.nextInt())); data.putShort(offset, (short)(data.getShort(offset) ^ random.nextInt()));
} }
for (int i = 0; i < 100; i++) { for (int i = 0; i < 100; i++) {
int offset = randomOffset(r, data, 4); int offset = randomOffset(r, data, 2);
data.putChar(offset, (char)(data.getChar(offset) ^ random.nextInt())); data.putChar(offset, (char)(data.getChar(offset) ^ random.nextInt()));
} }
for (int i = 0; i < 100; i++) { for (int i = 0; i < 100; i++) {
@ -345,14 +346,12 @@ public class HeapByteBufferTest implements Runnable {
} }
public void run() { public void run() {
SplittableRandom r = new SplittableRandom();
for (int i = 0; i < data.capacity(); i += 8) { for (int i = 0; i < data.capacity(); i += 8) {
data.putLong(i, random.nextLong()); data.putLong(i, random.nextLong());
} }
for (int i = 0; i < iterations; i++) { for (int i = 0; i < iterations; i++) {
step(r); step(random);
} }
if (!Arrays.equals(data.array(), data.backingArray())) { if (!Arrays.equals(data.array(), data.backingArray())) {