stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8158963: RMI server-side multiplex protocol should be disabled

Browse Source 
Add sun.rmi.transport.tcp.enableMultiplexProtocol to enable RMI multiplex protocol

Reviewed-by: smarks
This commit is contained in:
Roger Riggs 2016-11-02 13:42:03 -04:00
parent d86b93b397
commit 036a14e8a3
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
jdk/src/java.rmi/share/classes/sun/rmi/transport/tcp/TCPTransport.java
View File

@ -102,6 +102,11 @@ public class TCPTransport extends Transport {
AccessController.doPrivileged((PrivilegedAction<Long>) () -> AccessController.doPrivileged((PrivilegedAction<Long>) () ->
Long.getLong("sun.rmi.transport.tcp.threadKeepAliveTime", 60000)); Long.getLong("sun.rmi.transport.tcp.threadKeepAliveTime", 60000));
/** enable multiplexing protocol */
private static final boolean enableMultiplexProtocol = // default false
AccessController.doPrivileged((PrivilegedAction<Boolean>) () ->
Boolean.getBoolean("sun.rmi.transport.tcp.enableMultiplexProtocol"));
/** thread pool for connection handlers */ /** thread pool for connection handlers */
private static final ExecutorService connectionThreadPool = private static final ExecutorService connectionThreadPool =
new ThreadPoolExecutor(0, maxConnectionThreads, new ThreadPoolExecutor(0, maxConnectionThreads,
@ -796,6 +801,19 @@ public class TCPTransport extends Transport {
break; break;
case TransportConstants.MultiplexProtocol: case TransportConstants.MultiplexProtocol:
if (!enableMultiplexProtocol) {
if (tcpLog.isLoggable(Log.VERBOSE)) {
tcpLog.log(Log.VERBOSE, "(port " + port +
") rejecting multiplex protocol");
}
// If MultiplexProtocol is disabled, send NACK immediately.
out.writeByte(TransportConstants.ProtocolNack);
out.flush();
break;
}
if (tcpLog.isLoggable(Log.VERBOSE)) { if (tcpLog.isLoggable(Log.VERBOSE)) {
tcpLog.log(Log.VERBOSE, "(port " + port + tcpLog.log(Log.VERBOSE, "(port " + port +
") accepting multiplex protocol"); ") accepting multiplex protocol");