stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8233550: [TESTBUG] JTree tests fail regularly on MacOS

Browse Source 
Reviewed-by: psadhukhan, jdv
This commit is contained in:
Pankaj Bansal 2020-05-23 13:27:09 +05:30
parent 15433df97f
commit 04b3bf6024
4 changed files with 215 additions and 166 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/jdk/ProblemList.txt
View File

@ -836,9 +836,6 @@ javax/swing/text/JTextComponent/6361367/bug6361367.java 8233569 macosx-all
javax/swing/text/html/HTMLEditorKit/5043626/bug5043626.java 233570 macosx-all
javax/swing/ProgressMonitor/ProgressMonitorEscapeKeyPress.java 8233635 macosx-all
javax/swing/plaf/nimbus/TestNimbusOverride.java 8233559 macosx-all
javax/swing/JTree/4927934/bug4927934.java 8233550 macosx-all
javax/swing/JTree/4908142/bug4908142.java 8233550 macosx-all
javax/swing/JTree/4330357/bug4330357.java 8233550 macosx-all
javax/swing/JTable/7124218/SelectEditTableCell.java 8233551 macosx-all
javax/swing/JRootPane/4670486/bug4670486.java 8042381 macosx-all
javax/swing/JRadioButton/ButtonGroupFocus/ButtonGroupFocusTest.java 8233555 macosx-all

87
test/jdk/javax/swing/JTree/4330357/bug4330357.java
View File

@ -31,13 +31,34 @@
* @author Peter Zhelezniakov
* @run main bug4330357
*/
import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
import javax.swing.tree.*;
import java.awt.BorderLayout;
import java.awt.Component;
import java.awt.Dimension;
import java.awt.Point;
import java.awt.Rectangle;
import java.awt.Robot;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.awt.event.InputEvent;
import java.awt.event.KeyEvent;
import javax.swing.AbstractCellEditor;
import javax.swing.JButton;
import javax.swing.JComboBox;
import javax.swing.JFrame;
import javax.swing.JScrollPane;
import javax.swing.JTextField;
import javax.swing.JTree;
import javax.swing.SwingUtilities;
import javax.swing.UIManager;
import javax.swing.tree.DefaultTreeCellEditor;
import javax.swing.tree.DefaultTreeCellRenderer;
import javax.swing.tree.TreeCellEditor;
public class bug4330357 {
private static JFrame frame;
private static JTree tree;
private static JButton button;
private static Robot robot;
@ -48,38 +69,44 @@ public class bug4330357 {
UIManager.setLookAndFeel("javax.swing.plaf.metal.MetalLookAndFeel");
javax.swing.SwingUtilities.invokeAndWait(new Runnable() {
try {
javax.swing.SwingUtilities.invokeAndWait(new Runnable() {
public void run() {
createAndShowGUI();
public void run() {
createAndShowGUI();
}
});
robot.waitForIdle();
clickMouse(getTreeRowClickPoint(1));
Util.hitKeys(robot, KeyEvent.VK_F2);
Util.hitKeys(robot, KeyEvent.VK_A, KeyEvent.VK_B, KeyEvent.VK_C);
robot.waitForIdle();
if (!hasComponent(JTextField.class)) {
throw new RuntimeException("Cell editor is missed for path: color");
}
});
robot.waitForIdle();
clickMouse(getTreeRowClickPoint(1));
Util.hitKeys(robot, KeyEvent.VK_F2);
Util.hitKeys(robot, KeyEvent.VK_A, KeyEvent.VK_B, KeyEvent.VK_C);
robot.waitForIdle();
if (!hasComponent(JTextField.class)) {
throw new RuntimeException("Cell editor is missed for path: color");
}
clickMouse(getButtonClickPoint());
robot.waitForIdle();
clickMouse(getButtonClickPoint());
robot.waitForIdle();
clickMouse(getTreeRowClickPoint(2));
Util.hitKeys(robot, KeyEvent.VK_F2);
robot.waitForIdle();
clickMouse(getTreeRowClickPoint(2));
Util.hitKeys(robot, KeyEvent.VK_F2);
robot.waitForIdle();
if (!hasComponent(JComboBox.class)) {
throw new RuntimeException("Cell editor is missed for path: sports");
}
if (!hasComponent(JComboBox.class)) {
throw new RuntimeException("Cell editor is missed for path: sports");
}
if (hasComponent(JTextField.class)) {
throw new RuntimeException("Cell editor is wrongly shown for path: color");
if (hasComponent(JTextField.class)) {
throw new RuntimeException("Cell editor is wrongly shown for path: color");
}
} finally {
if (frame != null) {
SwingUtilities.invokeAndWait(frame::dispose);
}
}
}
@ -137,7 +164,7 @@ public class bug4330357 {
}
private static void createAndShowGUI() {
JFrame frame = new JFrame("Test");
frame = new JFrame("Test");
frame.setSize(200, 200);
frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);

94
test/jdk/javax/swing/JTree/4908142/bug4908142.java
View File

@ -32,65 +32,75 @@
* @build Util
* @run main bug4908142
*/
import javax.swing.*;
import javax.swing.tree.*;
import java.awt.*;
import java.awt.event.*;
import javax.swing.JFrame;
import javax.swing.JScrollPane;
import javax.swing.JTree;
import javax.swing.SwingUtilities;
import javax.swing.tree.DefaultMutableTreeNode;
import java.awt.Robot;
import java.awt.event.KeyEvent;
import java.util.concurrent.Callable;
public class bug4908142 {
private static JTree tree;
private static JFrame fr = null;
private static JTree tree = null;
public static void main(String[] args) throws Exception {
Robot robot = new Robot();
robot.setAutoDelay(50);
SwingUtilities.invokeAndWait(new Runnable() {
try {
SwingUtilities.invokeAndWait(new Runnable() {
public void run() {
createAndShowGUI();
public void run() {
createAndShowGUI();
}
});
robot.waitForIdle();
SwingUtilities.invokeAndWait(new Runnable() {
public void run() {
tree.requestFocus();
tree.setSelectionRow(0);
}
});
robot.waitForIdle();
robot.keyPress(KeyEvent.VK_A);
robot.keyRelease(KeyEvent.VK_A);
robot.keyPress(KeyEvent.VK_A);
robot.keyRelease(KeyEvent.VK_A);
robot.keyPress(KeyEvent.VK_D);
robot.keyRelease(KeyEvent.VK_D);
robot.waitForIdle();
String sel = Util.invokeOnEDT(new Callable<String>() {
@Override
public String call() throws Exception {
return tree.getLastSelectedPathComponent().toString();
}
});
if (!"aad".equals(sel)) {
throw new Error("The selected index should be \"aad\", but not " + sel);
}
});
robot.waitForIdle();
SwingUtilities.invokeAndWait(new Runnable() {
public void run() {
tree.requestFocus();
tree.setSelectionRow(0);
} finally {
if (fr != null) {
SwingUtilities.invokeAndWait(fr::dispose);
}
});
robot.waitForIdle();
robot.keyPress(KeyEvent.VK_A);
robot.keyRelease(KeyEvent.VK_A);
robot.keyPress(KeyEvent.VK_A);
robot.keyRelease(KeyEvent.VK_A);
robot.keyPress(KeyEvent.VK_D);
robot.keyRelease(KeyEvent.VK_D);
robot.waitForIdle();
String sel = Util.invokeOnEDT(new Callable<String>() {
@Override
public String call() throws Exception {
return tree.getLastSelectedPathComponent().toString();
}
});
if (!"aad".equals(sel)) {
throw new Error("The selected index should be \"aad\", but not " + sel);
}
}
private static void createAndShowGUI() {
JFrame fr = new JFrame("Test");
fr = new JFrame("Test");
fr.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
String[] data = {"aaa", "aab", "aac", "aad", "ade", "bba"};

197
test/jdk/javax/swing/JTree/4927934/bug4927934.java
View File

@ -22,19 +22,28 @@
*/
/*
@test
@key headful
@key headful
@bug 4927934
@summary JTree traversal is unlike Native windows tree traversal
@author Andrey Pikalev
@run main bug4927934
*/
import javax.swing.*;
import javax.swing.event.*;
import javax.swing.tree.*;
import java.awt.*;
import java.awt.event.*;
import java.lang.reflect.InvocationTargetException;
import java.awt.Robot;
import java.awt.event.FocusEvent;
import java.awt.event.FocusListener;
import java.awt.event.KeyEvent;
import javax.swing.JFrame;
import javax.swing.JTree;
import javax.swing.SwingUtilities;
import javax.swing.UIManager;
import javax.swing.JScrollPane;
import javax.swing.event.TreeSelectionListener;
import javax.swing.event.TreeExpansionListener;
import javax.swing.event.TreeSelectionEvent;
import javax.swing.event.TreeExpansionEvent;
import javax.swing.tree.DefaultMutableTreeNode;
public class bug4927934 implements TreeSelectionListener, TreeExpansionListener, FocusListener {
@ -55,107 +64,113 @@ public class bug4927934 implements TreeSelectionListener, TreeExpansionListener,
robot = new Robot();
robot.setAutoDelay(50);
SwingUtilities.invokeAndWait(new Runnable() {
public void run() {
frame = new JFrame();
try {
SwingUtilities.invokeAndWait(new Runnable() {
public void run() {
frame = new JFrame();
DefaultMutableTreeNode root = new DefaultMutableTreeNode("root");
createNodes(root);
tree = new JTree(root);
JScrollPane scrollPane = new JScrollPane(tree);
frame.getContentPane().add(scrollPane);
DefaultMutableTreeNode root = new DefaultMutableTreeNode("root");
createNodes(root);
tree = new JTree(root);
JScrollPane scrollPane = new JScrollPane(tree);
frame.getContentPane().add(scrollPane);
tree.addFocusListener((FocusListener)listener);
tree.addTreeSelectionListener((TreeSelectionListener)listener);
tree.addTreeExpansionListener((TreeExpansionListener)listener);
tree.addFocusListener((FocusListener) listener);
tree.addTreeSelectionListener((TreeSelectionListener) listener);
tree.addTreeExpansionListener((TreeExpansionListener) listener);
frame.setSize(300, 300);
frame.setVisible(true);
}
});
frame.setSize(300, 300);
frame.setVisible(true);
}
});
robot.waitForIdle();
Thread.sleep(1000);
robot.waitForIdle();
Thread.sleep(1000);
SwingUtilities.invokeLater(new Runnable() {
public void run() {
tree.requestFocus();
}
});
SwingUtilities.invokeLater(new Runnable() {
public void run() {
tree.requestFocus();
}
});
synchronized(listener) {
if (!focusGained) {
System.out.println("waiting focusGained...");
try {
listener.wait(10000);
} catch (InterruptedException e) {
e.printStackTrace();
synchronized (listener) {
if (!focusGained) {
System.out.println("waiting focusGained...");
try {
listener.wait(10000);
} catch (InterruptedException e) {
e.printStackTrace();
}
}
}
}
// GO TO RIGHT
selectionChanged = false;
hitKey(KeyEvent.VK_RIGHT);
robot.waitForIdle();
if (!checkSelectionChanged(tree, 0)) {
throw new RuntimeException("Root should be selected");
}
// GO TO RIGHT
selectionChanged = false;
hitKey(KeyEvent.VK_RIGHT);
robot.waitForIdle();
if (!checkSelectionChanged(tree, 0)) {
throw new RuntimeException("Root should be selected");
}
selectionChanged = false;
hitKey(KeyEvent.VK_RIGHT);
robot.waitForIdle();
if (!checkSelectionChanged(tree, 1)) {
throw new RuntimeException("Node should be selected");
}
selectionChanged = false;
hitKey(KeyEvent.VK_RIGHT);
robot.waitForIdle();
if (!checkSelectionChanged(tree, 1)) {
throw new RuntimeException("Node should be selected");
}
treeExpanded = false;
hitKey(KeyEvent.VK_RIGHT);
robot.waitForIdle();
if (!isTreeExpanded()) {
throw new RuntimeException("Node should be expanded");
}
treeExpanded = false;
hitKey(KeyEvent.VK_RIGHT);
robot.waitForIdle();
if (!isTreeExpanded()) {
throw new RuntimeException("Node should be expanded");
}
selectionChanged = false;
hitKey(KeyEvent.VK_RIGHT);
robot.waitForIdle();
if (!checkSelectionChanged(tree, 2)) {
throw new RuntimeException("Leaf1 should be selected");
}
selectionChanged = false;
hitKey(KeyEvent.VK_RIGHT);
robot.waitForIdle();
if (!checkSelectionChanged(tree, 2)) {
throw new RuntimeException("Leaf1 should be selected");
}
selectionChanged = false;
hitKey(KeyEvent.VK_RIGHT);
robot.waitForIdle();
if (!checkSelectionChanged(tree, 2)) {
throw new RuntimeException("Leaf1 should be selected");
}
selectionChanged = false;
hitKey(KeyEvent.VK_RIGHT);
robot.waitForIdle();
if (!checkSelectionChanged(tree, 2)) {
throw new RuntimeException("Leaf1 should be selected");
}
// GO TO LEFT
selectionChanged = false;
hitKey(KeyEvent.VK_LEFT);
robot.waitForIdle();
if (!checkSelectionChanged(tree, 1)) {
throw new RuntimeException("Node should be selected");
}
// GO TO LEFT
selectionChanged = false;
hitKey(KeyEvent.VK_LEFT);
robot.waitForIdle();
if (!checkSelectionChanged(tree, 1)) {
throw new RuntimeException("Node should be selected");
}
treeCollapsed = false;
hitKey(KeyEvent.VK_LEFT);
if (!isTreeCollapsed()) {
throw new RuntimeException("Node should be collapsed");
}
treeCollapsed = false;
hitKey(KeyEvent.VK_LEFT);
if (!isTreeCollapsed()) {
throw new RuntimeException("Node should be collapsed");
}
selectionChanged = false;
hitKey(KeyEvent.VK_LEFT);
robot.waitForIdle();
if (!checkSelectionChanged(tree, 0)) {
throw new RuntimeException("Root should be selected");
}
selectionChanged = false;
hitKey(KeyEvent.VK_LEFT);
robot.waitForIdle();
if (!checkSelectionChanged(tree, 0)) {
throw new RuntimeException("Root should be selected");
}
treeCollapsed = false;
hitKey(KeyEvent.VK_LEFT);
robot.waitForIdle();
if (!isTreeCollapsed()) {
throw new RuntimeException("Root should be collapsed");
treeCollapsed = false;
hitKey(KeyEvent.VK_LEFT);
robot.waitForIdle();
if (!isTreeCollapsed()) {
throw new RuntimeException("Root should be collapsed");
}
} finally {
if (frame != null) {
SwingUtilities.invokeAndWait(frame::dispose);
}
}
}