stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8274898: Cleanup usages of StringBuffer in jdk tools modules

Browse Source 
Reviewed-by: sspitsyn, lmesnik
This commit is contained in:
Andrey Turbanov 2021-12-15 19:28:58 +00:00 committed by Serguei Spitsyn
parent 7517c85da3
commit 04dbdd36dd
3 changed files with 8 additions and 8 deletions
src
jdk.jartool/share/classes/sun/security/tools/jarsigner
Main.java
jdk.jpackage/share/classes/jdk/jpackage/internal
Log.java
jdk.jshell/share/classes/jdk/internal/jshell/tool
Feedback.java

4
src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java

@ -834,9 +834,9 @@ public class Main {
}
// Only used when -verbose provided
StringBuffer sb = null;
StringBuilder sb = null;
if (verbose != null) {
sb = new StringBuffer();
sb = new StringBuilder();
boolean inManifest =
((man.getAttributes(name) != null) ||
(man.getAttributes("./"+name) != null) ||

8
src/jdk.jpackage/share/classes/jdk/jpackage/internal/Log.java

@ -108,7 +108,7 @@ public class Log {
public void verbose(List<String> strings,
List<String> output, int returnCode, long pid) {
if (verbose) {
StringBuffer sb = new StringBuffer();
StringBuilder sb = new StringBuilder();
sb.append("Command [PID: ");
sb.append(pid);
sb.append("]:\n ");
@ -116,13 +116,13 @@ public class Log {
for (String s : strings) {
sb.append(" " + s);
}
verbose(new String(sb));
verbose(sb.toString());
if (output != null && !output.isEmpty()) {
sb = new StringBuffer("Output:");
sb = new StringBuilder("Output:");
for (String s : output) {
sb.append("\n " + s);
}
verbose(new String(sb));
verbose(sb.toString());
}
verbose("Returned: " + returnCode + "\n");
}

4
src/jdk.jshell/share/classes/jdk/internal/jshell/tool/Feedback.java

@ -1,5 +1,5 @@
/*
* Copyright (c) 2016, 2020, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2016, 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@ -372,7 +372,7 @@ class Feedback {
return "";
}
Matcher m = FIELD_PATTERN.matcher(format);
StringBuffer sb = new StringBuffer(format.length());
StringBuilder sb = new StringBuilder(format.length());
while (m.find()) {
String fieldName = m.group(1);
String sub = format(fieldName, selector);