stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8030199: Nashorn: Uint8ClampedArray - Incorrect ToUint8Clamp implementation

Browse Source 
Reviewed-by: sundar, jlaskey, lagergren
This commit is contained in:
Hannes Wallnöfer 2014-04-14 17:43:38 +02:00
parent 87a0f4a044
commit 08bec4bee8
3 changed files with 73 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
nashorn/src/jdk/nashorn/internal/objects/NativeUint8ClampedArray.java
View File

@ -88,6 +88,15 @@ public final class NativeUint8ClampedArray extends ArrayBufferView {
buffer.getByteArray()[byteIndex(index)] = clamped;
}
@Override
protected void setImpl(final int index, final long value) {
if (JSType.isRepresentableAsInt(value)) {
setImpl(index, (int)value);
} else {
buffer.getByteArray()[byteIndex(index)] = value > 0 ? (byte)0xff : 0;
}
}
@Override
protected void setImpl(final int key, final double value) {
setImpl(key, (int)Math.rint(value));

50
nashorn/test/script/basic/JDK-8030199.js Normal file
View File

@ -0,0 +1,50 @@
/*
* Copyright (c) 2010, 2014, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/**
* JDK-8030199: Nashorn: Uint8ClampedArray - Incorrect ToUint8Clamp implementation
*
* @test
* @run
*/
function testTypedArray(ArrayType) {
print(ArrayType.BYTES_PER_ELEMENT);
var a = new ArrayType(7);
a[0] = 4294967296;
a[1] = -4294967295;
a[2] = 4294967298;
a[3] = -4294967298;
a[4] = Infinity;
a[5] = -Infinity;
a[6] = NaN;
print(Array.prototype.join.call(a));
}
testTypedArray(Uint8ClampedArray);
testTypedArray(Uint8Array);
testTypedArray(Int8Array);
testTypedArray(Uint16Array);
testTypedArray(Int16Array);
testTypedArray(Uint32Array);
testTypedArray(Int32Array);

14
nashorn/test/script/basic/JDK-8030199.js.EXPECTED Normal file
View File

@ -0,0 +1,14 @@
1
255,0,255,0,255,0,0
1
0,1,2,254,0,0,0
1
0,1,2,-2,0,0,0
2
0,1,2,65534,0,0,0
2
0,1,2,-2,0,0,0
4
0,1,2,4294967294,0,0,0
4
0,1,2,-2,0,0,0