stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8246557: test_os_linux.cpp uses NULL instead of MAP_FAILED to check for failed mmap call

Browse Source 
Reviewed-by: sjohanss, stefank
This commit is contained in:
Thomas Schatzl 2020-06-05 10:44:24 +02:00
parent d071ed0294
commit 0963050548
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/hotspot/gtest/runtime/test_os_linux.cpp
View File

@ -159,7 +159,7 @@ TEST_VM(os_linux, reserve_memory_special_huge_tlbfs_mixed_with_good_req_addr) {
char* const mapping = (char*) ::mmap(NULL, mapping_size,
PROT_NONE, MAP_PRIVATE|MAP_ANONYMOUS|MAP_NORESERVE,
-1, 0);
ASSERT_TRUE(mapping != NULL) << " mmap failed, mapping_size = " << mapping_size;
ASSERT_TRUE(mapping != MAP_FAILED) << " mmap failed, mapping_size = " << mapping_size;
// Unmap the mapping, it will serve as a value for a "good" req_addr
::munmap(mapping, mapping_size);
@ -199,7 +199,7 @@ TEST_VM(os_linux, reserve_memory_special_huge_tlbfs_mixed_with_bad_req_addr) {
char* const mapping = (char*) ::mmap(NULL, mapping_size,
PROT_NONE, MAP_PRIVATE|MAP_ANONYMOUS|MAP_NORESERVE,
-1, 0);
ASSERT_TRUE(mapping != NULL) << " mmap failed, mapping_size = " << mapping_size;
ASSERT_TRUE(mapping != MAP_FAILED) << " mmap failed, mapping_size = " << mapping_size;
// Leave the mapping intact, it will server as "bad" req_addr
class MappingHolder {