From 0d66689177b880035e4047399e3e64f461713562 Mon Sep 17 00:00:00 2001 From: Fei Yang Date: Tue, 19 Nov 2024 10:20:58 +0000 Subject: [PATCH] 8344393: RISC-V: Remove option UseRVVForBigIntegerShiftIntrinsics Reviewed-by: mli, fjiang --- src/hotspot/cpu/riscv/globals_riscv.hpp | 2 -- src/hotspot/cpu/riscv/stubGenerator_riscv.cpp | 2 +- src/hotspot/cpu/riscv/vm_version_riscv.cpp | 1 - .../ci/hotspot/riscv64/RISCV64HotSpotJVMCIBackendFactory.java | 3 --- .../jdk/vm/ci/hotspot/riscv64/RISCV64HotSpotVMConfig.java | 1 - .../share/classes/jdk/vm/ci/riscv64/RISCV64.java | 3 +-- 6 files changed, 2 insertions(+), 10 deletions(-) diff --git a/src/hotspot/cpu/riscv/globals_riscv.hpp b/src/hotspot/cpu/riscv/globals_riscv.hpp index cc3c3b4a63c..ffbb7c58911 100644 --- a/src/hotspot/cpu/riscv/globals_riscv.hpp +++ b/src/hotspot/cpu/riscv/globals_riscv.hpp @@ -117,8 +117,6 @@ define_pd_global(intx, InlineSmallCode, 1000); product(bool, UseZvfh, false, DIAGNOSTIC, "Use Zvfh instructions") \ product(bool, UseZvkn, false, EXPERIMENTAL, \ "Use Zvkn group extension, Zvkned, Zvknhb, Zvkb, Zvkt") \ - product(bool, UseRVVForBigIntegerShiftIntrinsics, true, \ - "Use RVV instructions for left/right shift of BigInteger") \ product(bool, UseCtxFencei, false, EXPERIMENTAL, \ "Use PR_RISCV_CTX_SW_FENCEI_ON to avoid explicit icache flush") diff --git a/src/hotspot/cpu/riscv/stubGenerator_riscv.cpp b/src/hotspot/cpu/riscv/stubGenerator_riscv.cpp index e4ae4f3cfd1..795e6882c6a 100644 --- a/src/hotspot/cpu/riscv/stubGenerator_riscv.cpp +++ b/src/hotspot/cpu/riscv/stubGenerator_riscv.cpp @@ -6502,7 +6502,7 @@ static const int64_t right_3_bits = right_n_bits(3); StubRoutines::_poly1305_processBlocks = generate_poly1305_processBlocks(); } - if (UseRVVForBigIntegerShiftIntrinsics) { + if (UseRVV) { StubRoutines::_bigIntegerLeftShiftWorker = generate_bigIntegerLeftShift(); StubRoutines::_bigIntegerRightShiftWorker = generate_bigIntegerRightShift(); } diff --git a/src/hotspot/cpu/riscv/vm_version_riscv.cpp b/src/hotspot/cpu/riscv/vm_version_riscv.cpp index 6e8ee1ab7e0..dddded795fa 100644 --- a/src/hotspot/cpu/riscv/vm_version_riscv.cpp +++ b/src/hotspot/cpu/riscv/vm_version_riscv.cpp @@ -233,7 +233,6 @@ void VM_Version::c2_initialize() { if (!UseRVV) { FLAG_SET_DEFAULT(MaxVectorSize, 0); - FLAG_SET_DEFAULT(UseRVVForBigIntegerShiftIntrinsics, false); } else { if (!FLAG_IS_DEFAULT(MaxVectorSize) && MaxVectorSize != _initial_vector_length) { warning("Current system does not support RVV vector length for MaxVectorSize %d. Set MaxVectorSize to %d", diff --git a/src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/riscv64/RISCV64HotSpotJVMCIBackendFactory.java b/src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/riscv64/RISCV64HotSpotJVMCIBackendFactory.java index f6d365f193b..9e7d7679cab 100644 --- a/src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/riscv64/RISCV64HotSpotJVMCIBackendFactory.java +++ b/src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/riscv64/RISCV64HotSpotJVMCIBackendFactory.java @@ -76,9 +76,6 @@ public class RISCV64HotSpotJVMCIBackendFactory implements HotSpotJVMCIBackendFac if (config.useZbb) { flags.add(RISCV64.Flag.UseZbb); } - if (config.useRVVForBigIntegerShiftIntrinsics) { - flags.add(RISCV64.Flag.UseRVVForBigIntegerShiftIntrinsics); - } return flags; } diff --git a/src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/riscv64/RISCV64HotSpotVMConfig.java b/src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/riscv64/RISCV64HotSpotVMConfig.java index 5af1a4b7796..7f19efc4566 100644 --- a/src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/riscv64/RISCV64HotSpotVMConfig.java +++ b/src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/riscv64/RISCV64HotSpotVMConfig.java @@ -50,7 +50,6 @@ class RISCV64HotSpotVMConfig extends HotSpotVMConfigAccess { final boolean useRVC = getFlag("UseRVC", Boolean.class); final boolean useZba = getFlag("UseZba", Boolean.class); final boolean useZbb = getFlag("UseZbb", Boolean.class); - final boolean useRVVForBigIntegerShiftIntrinsics = getFlag("UseRVVForBigIntegerShiftIntrinsics", Boolean.class); final long vmVersionFeatures = getFieldValue("Abstract_VM_Version::_features", Long.class, "uint64_t"); } diff --git a/src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/riscv64/RISCV64.java b/src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/riscv64/RISCV64.java index 91d7b79aad4..2da9d51cca2 100644 --- a/src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/riscv64/RISCV64.java +++ b/src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/riscv64/RISCV64.java @@ -170,8 +170,7 @@ public class RISCV64 extends Architecture { UseRVV, UseRVC, UseZba, - UseZbb, - UseRVVForBigIntegerShiftIntrinsics + UseZbb } private final EnumSet flags;