stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8209588: SIGSEGV in MethodArityHistogram() with -XX:+CountCompiledCalls

Browse Source 
Reviewed-by: kvn, goetz
This commit is contained in:
Lutz Schmidt 2018-08-20 17:25:45 +02:00
parent 55cf3de09b
commit 0f4805ef4c
1 changed files with 15 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/hotspot/share/runtime/sharedRuntime.cpp
View File

@ -2135,17 +2135,21 @@ class MethodArityHistogram {
static int _max_size; // max. arg size seen
static void add_method_to_histogram(nmethod* nm) {
Method* m = nm->method();
ArgumentCount args(m->signature());
int arity = args.size() + (m->is_static() ? 0 : 1);
int argsize = m->size_of_parameters();
arity = MIN2(arity, MAX_ARITY-1);
argsize = MIN2(argsize, MAX_ARITY-1);
int count = nm->method()->compiled_invocation_count();
_arity_histogram[arity] += count;
_size_histogram[argsize] += count;
_max_arity = MAX2(_max_arity, arity);
_max_size = MAX2(_max_size, argsize);
// These checks are taken from CodeHeapState::print_names()
Method* m = (nm == NULL) ? NULL : nm->method(); // nm->method() may be uninitialized, i.e. != NULL, but invalid
if ((nm != NULL) && (m != NULL) && !nm->is_zombie() && !nm->is_not_installed() &&
os::is_readable_pointer(m) && os::is_readable_pointer(m->constants())) {
ArgumentCount args(m->signature());
int arity = args.size() + (m->is_static() ? 0 : 1);
int argsize = m->size_of_parameters();
arity = MIN2(arity, MAX_ARITY-1);
argsize = MIN2(argsize, MAX_ARITY-1);
int count = nm->method()->compiled_invocation_count();
_arity_histogram[arity] += count;
_size_histogram[argsize] += count;
_max_arity = MAX2(_max_arity, arity);
_max_size = MAX2(_max_size, argsize);
}
}
void print_histogram_helper(int n, int* histo, const char* name) {