stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8213479: Missing x86_64.ad patterns for 8-bit logical operators with destination in memory

Browse Source 
Reviewed-by: kvn
This commit is contained in:
Bernard Blaser 2018-11-08 15:11:32 +01:00
parent e35e0ab165
commit 1117fcb339
2 changed files with 89 additions and 0 deletions
src/hotspot/cpu/x86
x86_64.ad
test/hotspot/jtreg/compiler/c2
Test8bitLogicalOperators.java

36
src/hotspot/cpu/x86/x86_64.ad

@ -9263,6 +9263,18 @@ instruct andI_rReg_mem(rRegI dst, memory src, rFlagsReg cr)
%}
// And Memory with Register
instruct andB_mem_rReg(memory dst, rRegI src, rFlagsReg cr)
%{
match(Set dst (StoreB dst (AndI (LoadB dst) src)));
effect(KILL cr);
ins_cost(150);
format %{ "andb $dst, $src\t# byte" %}
opcode(0x20);
ins_encode(REX_breg_mem(src, dst), OpcP, reg_mem(src, dst));
ins_pipe(ialu_mem_reg);
%}
instruct andI_mem_rReg(memory dst, rRegI src, rFlagsReg cr)
%{
match(Set dst (StoreI dst (AndI (LoadI dst) src)));
@ -9444,6 +9456,18 @@ instruct orI_rReg_mem(rRegI dst, memory src, rFlagsReg cr)
%}
// Or Memory with Register
instruct orB_mem_rReg(memory dst, rRegI src, rFlagsReg cr)
%{
match(Set dst (StoreB dst (OrI (LoadB dst) src)));
effect(KILL cr);
ins_cost(150);
format %{ "orb $dst, $src\t# byte" %}
opcode(0x08);
ins_encode(REX_breg_mem(src, dst), OpcP, reg_mem(src, dst));
ins_pipe(ialu_mem_reg);
%}
instruct orI_mem_rReg(memory dst, rRegI src, rFlagsReg cr)
%{
match(Set dst (StoreI dst (OrI (LoadI dst) src)));
@ -9520,6 +9544,18 @@ instruct xorI_rReg_mem(rRegI dst, memory src, rFlagsReg cr)
%}
// Xor Memory with Register
instruct xorB_mem_rReg(memory dst, rRegI src, rFlagsReg cr)
%{
match(Set dst (StoreB dst (XorI (LoadB dst) src)));
effect(KILL cr);
ins_cost(150);
format %{ "xorb $dst, $src\t# byte" %}
opcode(0x30);
ins_encode(REX_breg_mem(src, dst), OpcP, reg_mem(src, dst));
ins_pipe(ialu_mem_reg);
%}
instruct xorI_mem_rReg(memory dst, rRegI src, rFlagsReg cr)
%{
match(Set dst (StoreI dst (XorI (LoadI dst) src)));

53
test/hotspot/jtreg/compiler/c2/Test8bitLogicalOperators.java Normal file

@ -0,0 +1,53 @@
/*
* Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 8213479
* @summary Missing x86_64.ad patterns for 8-bit logical operators with destination in memory
*
* @run main/othervm -Xcomp -XX:-Inline -XX:CompileOnly=compiler.c2.Test8bitLogicalOperators::test
* compiler.c2.Test8bitLogicalOperators
*/
package compiler.c2;
public class Test8bitLogicalOperators {
private static byte and = 0b0011, or = 0b0011, xor = 0b0011;
private static byte mask = 0b0101;
public static void main(String... args) {
test();
if (and != 0b0001 || or != 0b0111 || xor != 0b0110)
throw new AssertionError("8-bit logical operator failure");
}
public static void test() {
and &= mask;
or |= mask;
xor ^= mask;
}
}