stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8268869: java in source-file mode suggests javac-only Xlint flags

Browse Source 
Reviewed-by: jjg
This commit is contained in:
Adam Sotona 2021-10-04 15:48:09 +00:00
parent f63c4a832a
commit 139a8334cb
2 changed files with 35 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/jdk.compiler/share/classes/com/sun/tools/javac/launcher/Main.java
View File

@ -352,7 +352,8 @@ public class Main {
// add implicit options
javacOpts.add("-proc:none");
javacOpts.add("-Xdiags:verbose");
javacOpts.add("-Xlint:deprecation");
javacOpts.add("-Xlint:unchecked");
return javacOpts;
}

34
test/langtools/tools/javac/launcher/SourceLauncherTest.java
View File

@ -23,7 +23,7 @@
/*
* @test
* @bug 8192920 8204588 8246774
* @bug 8192920 8204588 8246774 8248843 8268869
* @summary Test source launcher
* @library /tools/lib
* @modules jdk.compiler/com.sun.tools.javac.api
@ -598,6 +598,38 @@ public class SourceLauncherTest extends TestRunner {
"error: compilation failed");
}
@Test
public void testNoRecompileWithSuggestions(Path base) throws IOException {
tb.writeJavaFiles(base,
"class NoRecompile {\n" +
" void use(String s) {}\n" +
" void test() {\n" +
" use(1);\n" +
" }\n" +
" <T> void test(T t, Object o) {\n" +
" T t1 = (T) o;\n" +
" }\n" +
" static class Generic<T> {\n" +
" T t;\n" +
" void raw(Generic raw) {\n" +
" raw.t = \"\";\n" +
" }\n" +
" }\n" +
" void deprecation() {\n" +
" Thread.currentThread().stop();\n" +
" }\n" +
" void preview(Object o) {\n" +
" if (o instanceof String s) {\n" +
" System.out.println(s);\n" +
" }\n" +
" }\n" +
"}");
Result r = run(base.resolve("NoRecompile.java"), Collections.emptyList(), Collections.emptyList());
if (r.stdErr.contains("recompile with")) {
error("Unexpected recompile suggestions in error output: " + r.stdErr);
}
}
void testError(Path file, String expectStdErr, String expectFault) throws IOException {
Result r = run(file, Collections.emptyList(), List.of("1", "2", "3"));
checkEmpty("stdout", r.stdOut);