stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8200478: For boxing conversion javac uses Long.valueOf which does not guarantee caching according to its javadoc

Browse Source 
Reviewed-by: bpb
This commit is contained in:
Joe Darcy 2018-04-25 22:12:06 -07:00
parent 1515d70930
commit 15ef60b350
2 changed files with 5 additions and 7 deletions
src/java.base/share/classes/java/lang
Long.java
test/langtools/tools/javac/boxing
BoxingCaching.java

6
src/java.base/share/classes/java/lang/Long.java

@ -1164,10 +1164,8 @@ public final class Long extends Number implements Comparable<Long> {
* significantly better space and time performance by caching
* frequently requested values.
*
* Note that unlike the {@linkplain Integer#valueOf(int)
* corresponding method} in the {@code Integer} class, this method
* is <em>not</em> required to cache values within a particular
* range.
* This method will always cache values in the range -128 to 127,
* inclusive, and may cache other values outside of this range.
*
* @param l a long value.
* @return a {@code Long} instance representing {@code l}.

6
test/langtools/tools/javac/boxing/BoxingCaching.java

@ -1,5 +1,5 @@
/*
* Copyright (c) 2004, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2004, 2018, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@ -23,7 +23,7 @@
/*
* @test
* @bug 4990346
* @bug 4990346 8200478
* @summary Verify autoboxed values are cached as required.
* @author Joseph D. Darcy
*/
@ -155,7 +155,7 @@ public class BoxingCaching {
Long L = (long)(i-128);
if (L != results[i]) {
cached = false;
System.err.println("Integer value " + L +
System.err.println("Long value " + L +
" is not cached appropriately.");
}
}