stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8032587: Change silent failure in Attr.java to assertion

Browse Source 
Change silent failure in Attr.fromAttributes into a non-null assertion

Reviewed-by: jfranck
This commit is contained in:
Eric McCorkle 2014-01-24 08:47:32 -05:00
parent 69f2f2fad4
commit 1bb2245091
1 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
langtools/src/share/classes/com/sun/tools/javac/comp/Attr.java
View File

@ -4093,18 +4093,8 @@ public class Attr extends JCTree.Visitor {
ListBuffer<Attribute.TypeCompound> buf = new ListBuffer<>();
for (JCAnnotation anno : annotations) {
if (anno.attribute != null) {
// TODO: this null-check is only needed for an obscure
// ordering issue, where annotate.flush is called when
// the attribute is not set yet. For an example failure
// try the referenceinfos/NestedTypes.java test.
// Any better solutions?
buf.append((Attribute.TypeCompound) anno.attribute);
}
// Eventually we will want to throw an exception here, but
// we can't do that just yet, because it gets triggered
// when attempting to attach an annotation that isn't
// defined.
Assert.checkNonNull(anno.attribute);
buf.append((Attribute.TypeCompound) anno.attribute);
}
return buf.toList();
}