stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8312093: Incorrect javadoc comment text

Browse Source 
Reviewed-by: jlaskey
This commit is contained in:
Jan Lahoda 2023-07-17 06:43:16 +00:00
parent 37ca9024ef
commit 1c9691b1f7
2 changed files with 33 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java
View File

@ -1546,7 +1546,10 @@ public class JavaTokenizer extends UnicodeReader {
return;
}
skip('*');
if (skip('*') != 0 && is('/')) {
return ;
}
skipWhitespace();
if (isEOLN()) {

30
test/langtools/tools/javac/parser/JavacParserTest.java
View File

@ -23,7 +23,7 @@
/*
* @test
* @bug 7073631 7159445 7156633 8028235 8065753 8205418 8205913 8228451 8237041 8253584 8246774 8256411 8256149 8259050 8266436 8267221 8271928 8275097 8293897 8295401 8304671 8310326
* @bug 7073631 7159445 7156633 8028235 8065753 8205418 8205913 8228451 8237041 8253584 8246774 8256411 8256149 8259050 8266436 8267221 8271928 8275097 8293897 8295401 8304671 8310326 8312093
* @summary tests error and diagnostics positions
* @author Jan Lahoda
* @modules jdk.compiler/com.sun.tools.javac.api
@ -2420,6 +2420,34 @@ public class JavacParserTest extends TestCase {
}.scan(cut, null);
}
@Test //JDK-8312093
void testJavadoc() throws IOException {
String code = """
public class Test {
/***/
void main() {
}
}
""";
DiagnosticCollector<JavaFileObject> coll =
new DiagnosticCollector<>();
JavacTaskImpl ct = (JavacTaskImpl) tool.getTask(null, fm, coll, null,
null, Arrays.asList(new MyFileObject(code)));
Trees trees = Trees.instance(ct);
CompilationUnitTree cut = ct.parse().iterator().next();
new TreePathScanner<Void, Void>() {
@Override
public Void visitMethod(MethodTree node, Void p) {
if (!node.getName().contentEquals("main")) {
return null;
}
String comment = trees.getDocComment(getCurrentPath());
assertEquals("Expecting empty comment", "", comment);
return null;
}
}.scan(cut, null);
}
void run(String[] args) throws Exception {
int passed = 0, failed = 0;
final Pattern p = (args != null && args.length > 0)