From 1cf603e8fc5cb8dfd7d93bf2aa542de80d6290fb Mon Sep 17 00:00:00 2001 From: Christoph Dreis Date: Tue, 7 Jan 2020 15:33:09 -0800 Subject: [PATCH] 8236705: Use single character variant of String.replace when applicable Reviewed-by: igerasim, alanb --- .../share/classes/jdk/internal/module/ModulePath.java | 4 ++-- .../share/classes/jdk/internal/module/Resources.java | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/java.base/share/classes/jdk/internal/module/ModulePath.java b/src/java.base/share/classes/jdk/internal/module/ModulePath.java index 0accaaeac03..99713872588 100644 --- a/src/java.base/share/classes/jdk/internal/module/ModulePath.java +++ b/src/java.base/share/classes/jdk/internal/module/ModulePath.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2014, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2014, 2020, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -566,7 +566,7 @@ public class ModulePath implements ModuleFinder { if (attrs != null) { String mainClass = attrs.getValue(Attributes.Name.MAIN_CLASS); if (mainClass != null) { - mainClass = mainClass.replace("/", "."); + mainClass = mainClass.replace('/', '.'); if (Checks.isClassName(mainClass)) { String pn = packageName(mainClass); if (packages.contains(pn)) { diff --git a/src/java.base/share/classes/jdk/internal/module/Resources.java b/src/java.base/share/classes/jdk/internal/module/Resources.java index 924f262d776..f72137bcc94 100644 --- a/src/java.base/share/classes/jdk/internal/module/Resources.java +++ b/src/java.base/share/classes/jdk/internal/module/Resources.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2016, 2017, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2016, 2020, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -64,7 +64,7 @@ public final class Resources { if (index == -1 || index == name.length()-1) { return ""; } else { - return name.substring(0, index).replace("/", "."); + return name.substring(0, index).replace('/', '.'); } }