stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8334405: java/nio/channels/Selector/SelectWithConsumer.java#id0 failed in testWakeupDuringSelect

Browse Source 
Reviewed-by: dfuchs, alanb, vtewari
This commit is contained in:
Brian Burkhalter 2024-08-01 19:02:33 +00:00
parent f1fa64b6b6
commit 21e86d10a7
1 changed files with 37 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
test/jdk/java/nio/channels/Selector/SelectWithConsumer.java
View File

@ -1,5 +1,5 @@
/*
* Copyright (c) 2018, 2023, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2018, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@ -308,11 +308,10 @@ public class SelectWithConsumer {
Pipe.SinkChannel sink = p.sink();
source.configureBlocking(false);
source.register(sel, SelectionKey.OP_READ);
long start = System.currentTimeMillis();
long start = millisTime();
int n = sel.select(k -> assertTrue(false), 1000L);
long duration = System.currentTimeMillis() - start;
expectDuration(start, 500, Long.MAX_VALUE);
assertTrue(n == 0);
assertTrue(duration > 500, "select took " + duration + " ms");
} finally {
closePipe(p);
}
@ -332,11 +331,10 @@ public class SelectWithConsumer {
// select(Consumer, timeout)
try (Selector sel = Selector.open()) {
sel.wakeup();
long start = System.currentTimeMillis();
long start = millisTime();
int n = sel.select(k -> assertTrue(false), 60*1000);
long duration = System.currentTimeMillis() - start;
expectDuration(start, 0, 20_000);
assertTrue(n == 0);
assertTrue(duration < 5000, "select took " + duration + " ms");
}
}
@ -354,12 +352,10 @@ public class SelectWithConsumer {
// select(Consumer, timeout)
try (Selector sel = Selector.open()) {
scheduleWakeup(sel, 1, SECONDS);
long start = System.currentTimeMillis();
long start = millisTime();
int n = sel.select(k -> assertTrue(false), 60*1000);
long duration = System.currentTimeMillis() - start;
expectDuration(start, 0, 20_000);
assertTrue(n == 0);
assertTrue(duration > 500 && duration < 10*1000,
"select took " + duration + " ms");
}
}
@ -381,11 +377,10 @@ public class SelectWithConsumer {
// select(Consumer, timeout)
try (Selector sel = Selector.open()) {
Thread.currentThread().interrupt();
long start = System.currentTimeMillis();
long start = millisTime();
int n = sel.select(k -> assertTrue(false), 60*1000);
long duration = System.currentTimeMillis() - start;
expectDuration(start, 0, 20_000);
assertTrue(n == 0);
assertTrue(duration < 5000, "select took " + duration + " ms");
assertTrue(Thread.currentThread().isInterrupted());
assertTrue(sel.isOpen());
} finally {
@ -762,4 +757,32 @@ public class SelectWithConsumer {
throw new RuntimeException(e);
}
}
/**
* Returns the current time in milliseconds.
*/
private static long millisTime() {
long now = System.nanoTime();
return TimeUnit.MILLISECONDS.convert(now, TimeUnit.NANOSECONDS);
}
/**
* Check the duration of a task. The method will fail with an
* AssertionError if the millisecond duration does not satisfy:
*
* duration >= min && duration <= max
*
* Note that the inequalities are not strict, i.e., are inclusive.
*
* @param start start time, in milliseconds
* @param min minimum expected duration, in milliseconds
* @param max maximum expected duration, in milliseconds
*/
private static void expectDuration(long start, long min, long max) {
long duration = millisTime() - start;
assertTrue(duration >= min,
"Duration " + duration + "ms, expected >= " + min + "ms");
assertTrue(duration <= max,
"Duration " + duration + "ms, expected <= " + max + "ms");
}
}