6415065: Submenu is shown on wrong screen in multiple monitor environment

Reviewed-by: prr
This commit is contained in:
Sergei Tachenov 2023-09-21 09:00:26 +00:00 committed by Alexey Ushakov
parent ca47f5f06d
commit 23ed890f3f

View File

@ -478,6 +478,23 @@ public class JMenu extends JMenuItem implements Accessible,MenuElement
y = 0 - yOffset - pmSize.height; // Otherwise drop 'up'
}
}
// Note that the position may be later adjusted to fit the menu into the screen if possible.
// However, the code that does it (JPopupMenu.adjustPopupLocationToFitScreen) has no idea which screen
// to fit into, and determines it by the position calculated here, so we need to make sure it's on
// the correct screen, otherwise the menu may appear on the wrong screen (JDK-6415065).
// (Both x and y are relative to the JMenu position here, that's why we need these +-position.x/y here.)
if (position.y + y < screenBounds.y) { // Above the current screen?
y = screenBounds.y - position.y; // The top of the screen relative to this JMenu.
}
if (position.y + y >= screenBounds.y + screenBounds.height) { // Below the current screen?
y = screenBounds.y + screenBounds.height - 1 - position.y; // The bottom of the screen...
}
if (position.x + x < screenBounds.x) { // To the left of the current screen?
x = screenBounds.x - position.x; // The left edge of the screen...
}
if (position.x + x >= screenBounds.x + screenBounds.width) { // To the right of the current screen?
x = screenBounds.x + screenBounds.width - 1 - position.x; // The right edge of the screen...
}
return new Point(x,y);
}