stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8005789: Forgot to document -Dnashorn.unstable.relink.threshold

Browse Source 
Added documentation to DEVELOPER_README, fixed code convention warnings

Reviewed-by: attila
This commit is contained in:
Marcus Lagergren 2013-01-07 19:31:36 +01:00
parent 311f43d5a6
commit 24e583d55f
5 changed files with 17 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
nashorn/docs/DEVELOPER_README
View File

@ -13,6 +13,15 @@ properties described herein are subject to change without notice.
This documentation of the system property flags assume that the
default value of the flag is false, unless otherwise specified.
SYSTEM PROPERTY: -Dnashorn.unstable.relink.threshold=x
This property controls how many call site misses are allowed before a
callsite is relinked with "apply" semantics to never change again.
In the case of megamorphic callsites, this is necessary, or the
program would spend all its time swapping out callsite targets. Dynalink
has a default value (currently 8 relinks) for this property if it
is not explicitly set.
SYSTEM PROPERTY: -Dnashorn.callsiteaccess.debug

2
nashorn/src/jdk/nashorn/internal/codegen/CodeGenerator.java
View File

@ -130,13 +130,11 @@ import jdk.nashorn.internal.runtime.linker.LinkerCallSite;
* keeps track of the contents of the byte code stack. This way we avoid a large
* number of special cases on the form
* <pre>
* {@code
* if (type == INT) {
* visitInsn(ILOAD, slot);
* } else if (type == DOUBLE) {
* visitInsn(DOUBLE, slot);
* }
* }
* </pre>
* This quickly became apparent when the code generator was generalized to work
* with all types, and not just numbers or objects.

9
nashorn/src/jdk/nashorn/internal/codegen/Splitter.java
View File

@ -73,13 +73,14 @@ public class Splitter extends NodeVisitor {
/**
* Constructor.
*
* @param compiler the compiler
* @param functionNode function node to split
* @param compiler the compiler
* @param functionNode function node to split
* @param scriptCompileUnit script compile unit
*/
public Splitter(final Compiler compiler, final FunctionNode functionNode, final CompileUnit compileUnit) {
public Splitter(final Compiler compiler, final FunctionNode functionNode, final CompileUnit scriptCompileUnit) {
this.compiler = compiler;
this.functionNode = functionNode;
this.scriptCompileUnit = compileUnit;
this.scriptCompileUnit = scriptCompileUnit;
}
/**

3
nashorn/src/jdk/nashorn/internal/runtime/PropertyMap.java
View File

@ -176,9 +176,10 @@ public final class PropertyMap implements Iterable<Object>, PropertyListener {
/**
* Return a sharable empty map.
*
* @param context the context
* @return New empty {@link PropertyMap}.
*/
public static PropertyMap newEmptyMap(Context context) {
public static PropertyMap newEmptyMap(final Context context) {
return new PropertyMap(jdk.nashorn.internal.scripts.JO$.class, context, EMPTY_MAP);
}

2
nashorn/src/jdk/nashorn/internal/runtime/options/Options.java
View File

@ -493,7 +493,7 @@ public final class Options {
return new Option<>(value != null && Boolean.parseBoolean(value));
case "integer":
try {
return new Option<>((Integer)((value == null)? 0 : Integer.parseInt(value)));
return new Option<>((value == null) ? 0 : Integer.parseInt(value));
} catch (final NumberFormatException nfe) {
throw new IllegalOptionException(t);
}