stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8029091: Bug in calculation of code cache sweeping interval

Browse Source 
Use signed data type so that no underflow can happen

Reviewed-by: kvn, roland
This commit is contained in:
Albert Noll 2013-12-17 08:31:06 +01:00
parent 343c8d34a8
commit 2656f6d603
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
hotspot/src/share/vm/runtime/sweeper.cpp
View File

@ -257,9 +257,14 @@ void NMethodSweeper::possibly_sweep() {
// Large ReservedCodeCacheSize: (e.g., 256M + code Cache is 90% full). The formula // Large ReservedCodeCacheSize: (e.g., 256M + code Cache is 90% full). The formula
// computes: (256 / 16) - 10 = 6. // computes: (256 / 16) - 10 = 6.
if (!_should_sweep) { if (!_should_sweep) {
int time_since_last_sweep = _time_counter - _last_sweep; const int time_since_last_sweep = _time_counter - _last_sweep;
double wait_until_next_sweep = (ReservedCodeCacheSize / (16 * M)) - time_since_last_sweep - // ReservedCodeCacheSize has an 'unsigned' type. We need a 'signed' type for max_wait_time,
CodeCache::reverse_free_ratio(); // since 'time_since_last_sweep' can be larger than 'max_wait_time'. If that happens using
// an unsigned type would cause an underflow (wait_until_next_sweep becomes a large positive
// value) that disables the intended periodic sweeps.
const int max_wait_time = ReservedCodeCacheSize / (16 * M);
double wait_until_next_sweep = max_wait_time - time_since_last_sweep - CodeCache::reverse_free_ratio();
assert(wait_until_next_sweep <= (double)max_wait_time, "Calculation of code cache sweeper interval is incorrect");
if ((wait_until_next_sweep <= 0.0) || !CompileBroker::should_compile_new_jobs()) { if ((wait_until_next_sweep <= 0.0) || !CompileBroker::should_compile_new_jobs()) {
_should_sweep = true; _should_sweep = true;