8182284: G1Analytics uses uninitialized fields

Reviewed-by: tschatzl, sjohanss
This commit is contained in:
Erik Helin 2017-11-21 08:33:54 +01:00
parent 3d10c44a34
commit 26aa579a78
2 changed files with 38 additions and 1 deletions
src/hotspot/share/gc/g1
test/hotspot/gtest/gc/g1

@ -90,7 +90,9 @@ G1Analytics::G1Analytics(const G1Predictions* predictor) :
_non_young_other_cost_per_region_ms_seq(new TruncatedSeq(TruncatedSeqLength)),
_pending_cards_seq(new TruncatedSeq(TruncatedSeqLength)),
_rs_lengths_seq(new TruncatedSeq(TruncatedSeqLength)),
_recent_prev_end_times_for_all_gcs_sec(new TruncatedSeq(NumPrevPausesForHeuristics)) {
_recent_prev_end_times_for_all_gcs_sec(new TruncatedSeq(NumPrevPausesForHeuristics)),
_recent_avg_pause_time_ratio(0.0),
_last_pause_time_ratio(0.0) {
// Seed sequences with initial values.
_recent_prev_end_times_for_all_gcs_sec->add(os::elapsedTime());

@ -0,0 +1,35 @@
/*
* Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*
*/
#include "precompiled.hpp"
#include "gc/g1/g1Predictions.hpp"
#include "gc/g1/g1Analytics.hpp"
#include "unittest.hpp"
TEST_VM(G1Analytics, is_initialized) {
G1Predictions p(0.888888); // the actual sigma value doesn't matter
G1Analytics a(&p);
ASSERT_EQ(a.recent_avg_pause_time_ratio(), 0.0);
ASSERT_EQ(a.last_pause_time_ratio(), 0.0);
}