8321410: Shenandoah: Remove ShenandoahSuspendibleWorkers flag

Reviewed-by: rkennke
This commit is contained in:
Aleksey Shipilev 2023-12-06 21:17:19 +00:00
parent f4822605af
commit 2830dd2a7d
6 changed files with 7 additions and 40 deletions

@ -57,7 +57,7 @@ public:
void work(uint worker_id) {
ShenandoahHeap* heap = ShenandoahHeap::heap();
ShenandoahConcurrentWorkerSession worker_session(worker_id);
ShenandoahSuspendibleThreadSetJoiner stsj(ShenandoahSuspendibleWorkers);
ShenandoahSuspendibleThreadSetJoiner stsj;
ShenandoahReferenceProcessor* rp = heap->ref_processor();
assert(rp != nullptr, "need reference processor");
StringDedup::Requests requests;

@ -1023,7 +1023,7 @@ public:
void work(uint worker_id) {
if (_concurrent) {
ShenandoahConcurrentWorkerSession worker_session(worker_id);
ShenandoahSuspendibleThreadSetJoiner stsj(ShenandoahSuspendibleWorkers);
ShenandoahSuspendibleThreadSetJoiner stsj;
ShenandoahEvacOOMScope oom_evac_scope;
do_work();
} else {
@ -2056,7 +2056,7 @@ public:
void work(uint worker_id) {
if (CONCURRENT) {
ShenandoahConcurrentWorkerSession worker_session(worker_id);
ShenandoahSuspendibleThreadSetJoiner stsj(ShenandoahSuspendibleWorkers);
ShenandoahSuspendibleThreadSetJoiner stsj;
do_work<ShenandoahConcUpdateRefsClosure>();
} else {
ShenandoahParallelWorkerSession worker_session(worker_id);
@ -2238,15 +2238,11 @@ bool ShenandoahHeap::uncommit_bitmap_slice(ShenandoahHeapRegion *r) {
}
void ShenandoahHeap::safepoint_synchronize_begin() {
if (ShenandoahSuspendibleWorkers) {
SuspendibleThreadSet::synchronize();
}
SuspendibleThreadSet::synchronize();
}
void ShenandoahHeap::safepoint_synchronize_end() {
if (ShenandoahSuspendibleWorkers) {
SuspendibleThreadSet::desynchronize();
}
SuspendibleThreadSet::desynchronize();
}
void ShenandoahHeap::entry_uncommit(double shrink_before, size_t shrink_until) {

@ -256,7 +256,7 @@ inline bool ShenandoahHeap::cancelled_gc() const {
}
inline bool ShenandoahHeap::check_cancelled_gc_and_yield(bool sts_active) {
if (sts_active && ShenandoahSuspendibleWorkers && !cancelled_gc()) {
if (sts_active && !cancelled_gc()) {
if (SuspendibleThreadSet::should_yield()) {
SuspendibleThreadSet::yield();
}

@ -185,7 +185,7 @@ void ShenandoahMark::mark_loop_work(T* cl, ShenandoahLiveData* live_data, uint w
if (work == 0) {
// No work encountered in current stride, try to terminate.
// Need to leave the STS here otherwise it might block safepoints.
ShenandoahSuspendibleThreadSetLeaver stsl(CANCELLABLE && ShenandoahSuspendibleWorkers);
ShenandoahSuspendibleThreadSetLeaver stsl(CANCELLABLE);
ShenandoahTerminatorTerminator tt(heap);
if (terminator->offer_termination(&tt)) return;
}

@ -331,9 +331,6 @@
"How many times to maximum attempt to flush SATB buffers at the " \
"end of concurrent marking.") \
\
product(bool, ShenandoahSuspendibleWorkers, true, EXPERIMENTAL, \
"Suspend concurrent GC worker threads at safepoints") \
\
product(bool, ShenandoahSATBBarrier, true, DIAGNOSTIC, \
"Turn on/off SATB barriers in Shenandoah") \
\

@ -76,12 +76,6 @@
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockDiagnosticVMOptions -XX:+UnlockExperimentalVMOptions
* -XX:+UseShenandoahGC -XX:ShenandoahGCHeuristics=aggressive
* TestAllocObjects
*
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockDiagnosticVMOptions -XX:+UnlockExperimentalVMOptions
* -XX:+UseShenandoahGC -XX:ShenandoahGCHeuristics=aggressive
* -XX:+ShenandoahSuspendibleWorkers
* TestAllocObjects
*
*/
/*
@ -97,11 +91,6 @@
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockDiagnosticVMOptions -XX:+UnlockExperimentalVMOptions
* -XX:+UseShenandoahGC -XX:ShenandoahGCHeuristics=adaptive
* TestAllocObjects
*
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockDiagnosticVMOptions -XX:+UnlockExperimentalVMOptions
* -XX:+UseShenandoahGC -XX:ShenandoahGCHeuristics=adaptive
* -XX:+ShenandoahSuspendibleWorkers
* TestAllocObjects
*/
/*
@ -112,11 +101,6 @@
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockDiagnosticVMOptions -XX:+UnlockExperimentalVMOptions
* -XX:+UseShenandoahGC -XX:ShenandoahGCHeuristics=static
* TestAllocObjects
*
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockDiagnosticVMOptions -XX:+UnlockExperimentalVMOptions
* -XX:+UseShenandoahGC -XX:ShenandoahGCHeuristics=static
* -XX:+ShenandoahSuspendibleWorkers
* TestAllocObjects
*/
/*
@ -127,11 +111,6 @@
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockDiagnosticVMOptions -XX:+UnlockExperimentalVMOptions
* -XX:+UseShenandoahGC -XX:ShenandoahGCHeuristics=compact
* TestAllocObjects
*
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockDiagnosticVMOptions -XX:+UnlockExperimentalVMOptions
* -XX:+UseShenandoahGC -XX:ShenandoahGCHeuristics=compact
* -XX:+ShenandoahSuspendibleWorkers
* TestAllocObjects
*/
/*
@ -177,11 +156,6 @@
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockDiagnosticVMOptions -XX:+UnlockExperimentalVMOptions
* -XX:+UseShenandoahGC -XX:ShenandoahGCMode=iu
* TestAllocObjects
*
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockDiagnosticVMOptions -XX:+UnlockExperimentalVMOptions
* -XX:+UseShenandoahGC -XX:ShenandoahGCMode=iu
* -XX:+ShenandoahSuspendibleWorkers
* TestAllocObjects
*/
public class TestAllocObjects {