stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8020758: HttpCookie constructor does not throw IAE when name contains a space

Browse Source 
Reviewed-by: michaelm, msheppar
This commit is contained in:
Chris Hegarty 2013-10-23 14:38:22 +01:00
parent 92bd2a8b2d
commit 28fc7fbaeb
2 changed files with 5 additions and 2 deletions
jdk
src/share/classes/java/net
HttpCookie.java
test/java/net/CookieHandler
TestHttpCookie.java

2
jdk/src/share/classes/java/net/HttpCookie.java

@ -761,7 +761,7 @@ public final class HttpCookie implements Cloneable {
// from RFC 2068, token special case characters // from RFC 2068, token special case characters
// //
// private static final String tspecials = "()<>@,;:\\\"/[]?={} \t"; // private static final String tspecials = "()<>@,;:\\\"/[]?={} \t";
private static final String tspecials = ",;"; private static final String tspecials = ",; "; // deliberately includes space
/* /*
* Tests a string and returns true if the string counts as a token. * Tests a string and returns true if the string counts as a token.

5
jdk/test/java/net/CookieHandler/TestHttpCookie.java

@ -24,7 +24,7 @@
/** /**
* @test * @test
* @summary Unit test for java.net.HttpCookie * @summary Unit test for java.net.HttpCookie
* @bug 6244040 6277796 6277801 6277808 6294071 6692802 6790677 6901170 * @bug 6244040 6277796 6277801 6277808 6294071 6692802 6790677 6901170 8020758
* @author Edward Wang * @author Edward Wang
*/ */
@ -381,6 +381,9 @@ public class TestHttpCookie {
// CR 6692802: HttpOnly flag // CR 6692802: HttpOnly flag
test("set-cookie: CUSTOMER=WILE_E_COYOTE;HttpOnly").httpOnly(true); test("set-cookie: CUSTOMER=WILE_E_COYOTE;HttpOnly").httpOnly(true);
test("set-cookie: CUSTOMER=WILE_E_COYOTE").httpOnly(false); test("set-cookie: CUSTOMER=WILE_E_COYOTE").httpOnly(false);
// space disallowed in name (both Netscape and RFC2965)
test("set-cookie: CUST OMER=WILE_E_COYOTE").nil();
} }
static void header(String prompt) { static void header(String prompt) {