stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8180019: javadoc should treat failure to access URL as an error, not a warning

Browse Source 
Reviewed-by: jjg
This commit is contained in:
Kumar Srinivasan 2017-11-21 13:17:06 -08:00
parent 7fe35f784b
commit 2af00f5da9
3 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Extern.java
View File

@ -223,7 +223,7 @@ public class Extern {
}
return true;
} catch (Fault f) {
reporter.print(Diagnostic.Kind.WARNING, f.getMessage());
reporter.print(Diagnostic.Kind.ERROR, f.getMessage());
return false;
}
}

9
test/langtools/jdk/javadoc/doclet/testLinkOption/TestBadLinkOption.java
View File

@ -23,8 +23,8 @@
/*
* @test
* @bug 4625883
* @summary Make sure that bad -link arguments trigger warnings.
* @bug 4625883 8180019
* @summary Make sure that bad -link arguments trigger errors.
* @author jamieh
* @library ../lib
* @modules jdk.javadoc/jdk.javadoc.internal.tool
@ -44,11 +44,10 @@ public class TestBadLinkOption extends JavadocTester {
String out = "out";
javadoc("-d", out,
"-sourcepath", testSrc,
"-link", out,
"-link", "a-non-existent-link",
"pkg");
checkExit(Exit.OK);
checkExit(Exit.ERROR);
// TODO: the file it is trying to read, out/out/package-list, warrants investigation
checkOutput(Output.OUT, true,
"Error reading file:");
}

2
test/langtools/jdk/javadoc/doclet/testLinkOption/TestNewLineInLink.java
View File

@ -44,7 +44,7 @@ public class TestNewLineInLink extends JavadocTester {
void test() {
javadoc("-d", "out",
"-sourcepath", testSrc,
"-linkoffline", "http://www.java.sun.com/j2se/1.4/docs/api", testSrc,
"-linkoffline", "http://www.java.sun.com/j2se/1.4/docs/api", testSrc("jdk"),
"testNewLineInLink");
checkExit(Exit.OK);