From 2c3844609c6f0bcf112fa35207875796282962c6 Mon Sep 17 00:00:00 2001 From: Anton Nashatyrev Date: Thu, 23 Apr 2015 17:33:19 +0300 Subject: [PATCH] 8078165: [macosx] NPE when attempting to get image from toolkit Reviewed-by: serb, alexp --- .../share/classes/sun/awt/SunToolkit.java | 9 ++-- .../java/awt/Toolkit/GetImage/bug8078165.java | 50 +++++++++++++++++++ 2 files changed, 56 insertions(+), 3 deletions(-) create mode 100644 jdk/test/java/awt/Toolkit/GetImage/bug8078165.java diff --git a/jdk/src/java.desktop/share/classes/sun/awt/SunToolkit.java b/jdk/src/java.desktop/share/classes/sun/awt/SunToolkit.java index ccb7fbb030d..91b555a2fce 100644 --- a/jdk/src/java.desktop/share/classes/sun/awt/SunToolkit.java +++ b/jdk/src/java.desktop/share/classes/sun/awt/SunToolkit.java @@ -843,14 +843,17 @@ public abstract class SunToolkit extends Toolkit } protected static boolean imageExists(String filename) { - checkPermissions(filename); - return filename != null && new File(filename).exists(); + if (filename != null) { + checkPermissions(filename); + return new File(filename).exists(); + } + return false; } @SuppressWarnings("try") protected static boolean imageExists(URL url) { - checkPermissions(url); if (url != null) { + checkPermissions(url); try (InputStream is = url.openStream()) { return true; }catch(IOException e){ diff --git a/jdk/test/java/awt/Toolkit/GetImage/bug8078165.java b/jdk/test/java/awt/Toolkit/GetImage/bug8078165.java new file mode 100644 index 00000000000..81ebc8a8618 --- /dev/null +++ b/jdk/test/java/awt/Toolkit/GetImage/bug8078165.java @@ -0,0 +1,50 @@ +/* + * Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + + +import java.awt.*; +import java.net.URL; +import java.security.Permission; + + +/** + * @test + * @bug 8078165 + * @summary NPE when attempting to get image from toolkit + * @author Anton Nashatyrev + */ +public final class bug8078165 { + + public static void main(final String[] args) throws Exception { + // Mac only + System.setSecurityManager(new SecurityManager() { + @Override + public void checkPermission(Permission permission) { + // Just allows everything + } + }); + // The method shouldn't throw NPE + Toolkit.getDefaultToolkit().getImage(new URL("file://./dummyImage@2x.png")); + Toolkit.getDefaultToolkit().getImage("./dummyImage@2x.png"); + } +}