stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8231953: Wrong assumption in assertion in oop::register_oop

Browse Source 
On ARM32 thumb mode, the pc of the current frame is always zero

Reviewed-by: coleenp, dcubed
This commit is contained in:
Christoph Goettschkes 2019-10-24 08:49:21 -04:00 committed by Coleen Phillimore
parent 89cdeeb6fe
commit 31ab60e211
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/hotspot/share/oops/oopsHierarchy.cpp
View File

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2005, 2015, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 2005, 2019, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
* *
* This code is free software; you can redistribute it and/or modify it * This code is free software; you can redistribute it and/or modify it
@ -37,8 +37,6 @@ void oop::register_oop() {
Thread* t = Thread::current_or_null(); Thread* t = Thread::current_or_null();
if (t != NULL && t->is_Java_thread()) { if (t != NULL && t->is_Java_thread()) {
frame fr = os::current_frame(); frame fr = os::current_frame();
// This points to the oop creator, I guess current frame points to caller
assert (fr.pc(), "should point to a vm frame");
t->unhandled_oops()->register_unhandled_oop(this, fr.pc()); t->unhandled_oops()->register_unhandled_oop(this, fr.pc());
} }
} }