From 33f5aae0ffb362d954b35d8203072757adec02e2 Mon Sep 17 00:00:00 2001 From: Vicente Romero Date: Wed, 29 May 2013 10:56:29 +0100 Subject: [PATCH] 7053059: VerifyError with double Assignment using a Generic Member of a Superclass Reviewed-by: mcimadamore --- .../com/sun/tools/javac/comp/TransTypes.java | 11 ++-- .../VerifyErrorWithDoubleAssignmentTest.java | 51 +++++++++++++++++++ 2 files changed, 58 insertions(+), 4 deletions(-) create mode 100644 langtools/test/tools/javac/T7053059/VerifyErrorWithDoubleAssignmentTest.java diff --git a/langtools/src/share/classes/com/sun/tools/javac/comp/TransTypes.java b/langtools/src/share/classes/com/sun/tools/javac/comp/TransTypes.java index a58dec6f7f1..4c227425149 100644 --- a/langtools/src/share/classes/com/sun/tools/javac/comp/TransTypes.java +++ b/langtools/src/share/classes/com/sun/tools/javac/comp/TransTypes.java @@ -172,10 +172,13 @@ public class TransTypes extends TreeTranslator { JCExpression retype(JCExpression tree, Type erasedType, Type target) { // System.err.println("retype " + tree + " to " + erasedType);//DEBUG if (!erasedType.isPrimitive()) { - if (target != null && target.isPrimitive()) + if (target != null && target.isPrimitive()) { target = erasure(tree.type); + } tree.type = erasedType; - if (target != null) return coerce(tree, target); + if (target != null) { + return coerce(tree, target); + } } return tree; } @@ -686,8 +689,8 @@ public class TransTypes extends TreeTranslator { public void visitAssign(JCAssign tree) { tree.lhs = translate(tree.lhs, null); tree.rhs = translate(tree.rhs, erasure(tree.lhs.type)); - tree.type = erasure(tree.type); - result = tree; + tree.type = erasure(tree.lhs.type); + result = retype(tree, tree.type, pt); } public void visitAssignop(JCAssignOp tree) { diff --git a/langtools/test/tools/javac/T7053059/VerifyErrorWithDoubleAssignmentTest.java b/langtools/test/tools/javac/T7053059/VerifyErrorWithDoubleAssignmentTest.java new file mode 100644 index 00000000000..e03b1a54874 --- /dev/null +++ b/langtools/test/tools/javac/T7053059/VerifyErrorWithDoubleAssignmentTest.java @@ -0,0 +1,51 @@ +/* + * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + * @test + * @bug 7053059 + * @summary VerifyError with double Assignment using a Generic Member of a Superclass + * @run main VerifyErrorWithDoubleAssignmentTest + */ + +public class VerifyErrorWithDoubleAssignmentTest { + + static class A { + D d; + + D getD() { + return null; + } + } + + static class B extends A { + Integer y; + B() { + y = d = getD(); + } + } + + public static void main(String[] args) { + new B(); + } +}