stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8196294: LoopStripMiningIterShortLoop is set to zero by default

Browse Source 
Reviewed-by: shade, thartmann, kvn
This commit is contained in:
Roland Westrelin 2018-03-21 10:05:36 +01:00
parent 957f5e1c7d
commit 35460b0e85
2 changed files with 54 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/hotspot/share/runtime/arguments.cpp
View File

@ -2342,10 +2342,6 @@ bool Arguments::check_vm_args_consistency() {
} }
LoopStripMiningIter = 0; LoopStripMiningIter = 0;
} }
if (FLAG_IS_DEFAULT(LoopStripMiningIterShortLoop)) {
// blind guess
LoopStripMiningIterShortLoop = LoopStripMiningIter / 10;
}
#endif #endif
if (!FLAG_IS_DEFAULT(AllocateHeapAt)) { if (!FLAG_IS_DEFAULT(AllocateHeapAt)) {
if ((UseNUMAInterleaving && !FLAG_IS_DEFAULT(UseNUMAInterleaving)) || (UseNUMA && !FLAG_IS_DEFAULT(UseNUMA))) { if ((UseNUMAInterleaving && !FLAG_IS_DEFAULT(UseNUMAInterleaving)) || (UseNUMA && !FLAG_IS_DEFAULT(UseNUMA))) {
@ -4339,6 +4335,10 @@ jint Arguments::apply_ergo() {
// nothing to use the profiling, turn if off // nothing to use the profiling, turn if off
FLAG_SET_DEFAULT(TypeProfileLevel, 0); FLAG_SET_DEFAULT(TypeProfileLevel, 0);
} }
if (FLAG_IS_DEFAULT(LoopStripMiningIterShortLoop)) {
// blind guess
LoopStripMiningIterShortLoop = LoopStripMiningIter / 10;
}
#endif #endif
if (PrintAssembly && FLAG_IS_DEFAULT(DebugNonSafepoints)) { if (PrintAssembly && FLAG_IS_DEFAULT(DebugNonSafepoints)) {

50
test/hotspot/jtreg/compiler/loopstripmining/CheckLoopStripMiningIterShortLoop.java Normal file
View File

@ -0,0 +1,50 @@
/*
* Copyright (c) 2018, Red Hat, Inc. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 8196294
* @summary when loop strip is enabled, LoopStripMiningIterShortLoop should be not null
* @library /test/lib /
* @modules java.base/jdk.internal.misc
* java.management
* @run driver CheckLoopStripMiningIterShortLoop
*/
import jdk.test.lib.process.OutputAnalyzer;
import jdk.test.lib.process.ProcessTools;
public class CheckLoopStripMiningIterShortLoop {
public static void main(String[] args) throws Exception {
ProcessBuilder pb = ProcessTools.createJavaProcessBuilder("-XX:+UseG1GC", "-XX:+PrintFlagsFinal", "-version");
OutputAnalyzer out = new OutputAnalyzer(pb.start());
long iter = Long.parseLong(out.firstMatch("uintx LoopStripMiningIter = (\\d+)", 1));
long iterShort = Long.parseLong(out.firstMatch("uintx LoopStripMiningIterShortLoop = (\\d+)", 1));
if (iter <= 0 || iterShort <= 0) {
throw new RuntimeException("Bad defaults for loop strip mining");
}
}
}