stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8293808: mscapi destroyKeyContainer enhance KeyStoreException: Access is denied exception

Browse Source 
Reviewed-by: weijun
This commit is contained in:
Matthias Baesken 2022-09-19 07:39:02 +00:00
parent cbd0688b32
commit 36c9034ff1
1 changed files with 31 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp
View File

@ -128,22 +128,43 @@ void ThrowExceptionWithMessage(JNIEnv *env, const char *exceptionName,
} }
} }
/* void ThrowExceptionWithMessageAndErrcode(JNIEnv *env, const char *exceptionName,
* Throws an arbitrary Java exception. const char *msg, DWORD dwError) {
* The exception message is a Windows system error message. char szMessage[500];
*/
void ThrowException(JNIEnv *env, const char *exceptionName, DWORD dwError)
{
char szMessage[1024];
szMessage[0] = '\0'; szMessage[0] = '\0';
char szMessage2[1024];
szMessage2[0] = '\0';
DWORD res = FormatMessageA(FORMAT_MESSAGE_FROM_SYSTEM, NULL, dwError, DWORD res = FormatMessageA(FORMAT_MESSAGE_FROM_SYSTEM, NULL, dwError,
NULL, szMessage, sizeof(szMessage), NULL); NULL, szMessage, sizeof(szMessage), NULL);
if (res == 0) { if (res == 0) {
strcpy(szMessage, "Unknown error"); strcpy(szMessage, "Unknown error");
} }
snprintf(szMessage2, sizeof(szMessage2), "%s: error %lu, %s", msg, dwError, szMessage);
ThrowExceptionWithMessage(env, exceptionName, szMessage); ThrowExceptionWithMessage(env, exceptionName, szMessage2);
}
/*
* Throws an arbitrary Java exception.
* The exception message is a Windows system error message.
*/
void ThrowException(JNIEnv *env, const char *exceptionName, DWORD dwError)
{
char szMessage[500];
szMessage[0] = '\0';
char szMessage2[1024];
szMessage2[0] = '\0';
DWORD res = FormatMessageA(FORMAT_MESSAGE_FROM_SYSTEM, NULL, dwError,
NULL, szMessage, sizeof(szMessage), NULL);
if (res == 0) {
strcpy(szMessage, "Unknown error");
}
snprintf(szMessage2, sizeof(szMessage2), "error %lu, %s", dwError, szMessage);
ThrowExceptionWithMessage(env, exceptionName, szMessage2);
} }
/* /*
@ -1845,8 +1866,7 @@ JNIEXPORT void JNICALL Java_sun_security_mscapi_CKeyStore_destroyKeyContainer
// Destroying the default key container is not permitted // Destroying the default key container is not permitted
// (because it may contain more one keypair). // (because it may contain more one keypair).
if (pszKeyContainerName == NULL) { if (pszKeyContainerName == NULL) {
ThrowExceptionWithMessage(env, KEYSTORE_EXCEPTION, "key container name was NULL, NTE_BAD_KEYSET_PARAM");
ThrowException(env, KEYSTORE_EXCEPTION, NTE_BAD_KEYSET_PARAM);
__leave; __leave;
} }
@ -1858,7 +1878,7 @@ JNIEXPORT void JNICALL Java_sun_security_mscapi_CKeyStore_destroyKeyContainer
PROV_RSA_FULL, PROV_RSA_FULL,
CRYPT_DELETEKEYSET) == FALSE) CRYPT_DELETEKEYSET) == FALSE)
{ {
ThrowException(env, KEYSTORE_EXCEPTION, GetLastError()); ThrowExceptionWithMessageAndErrcode(env, KEYSTORE_EXCEPTION, "CryptAcquireContext failure", GetLastError());
__leave; __leave;
} }