From 39aba3b4cf7d70219f03b98cdb18e2b11e14eacf Mon Sep 17 00:00:00 2001 From: Chris Hegarty Date: Mon, 18 Jul 2011 22:25:58 +0100 Subject: [PATCH] 7021280: SocketPermission should accept wildcards Reviewed-by: michaelm --- .../classes/java/net/SocketPermission.java | 10 ++++- .../java/net/SocketPermission/Wildcard.java | 45 +++++++++++++++++++ 2 files changed, 53 insertions(+), 2 deletions(-) create mode 100644 jdk/test/java/net/SocketPermission/Wildcard.java diff --git a/jdk/src/share/classes/java/net/SocketPermission.java b/jdk/src/share/classes/java/net/SocketPermission.java index 41fbdbf9552..a0fdbb8cc31 100644 --- a/jdk/src/share/classes/java/net/SocketPermission.java +++ b/jdk/src/share/classes/java/net/SocketPermission.java @@ -956,10 +956,16 @@ implements java.io.Serializable String thisHost = hostname; String thatHost = that.hostname; - if (thisHost == null) + if (thisHost == null) { return false; - else + } else if (this.wildcard) { + final int cnameLength = this.cname.length(); + return thatHost.regionMatches(true, + (thatHost.length() - cnameLength), + this.cname, 0, cnameLength); + } else { return thisHost.equalsIgnoreCase(thatHost); + } } /** diff --git a/jdk/test/java/net/SocketPermission/Wildcard.java b/jdk/test/java/net/SocketPermission/Wildcard.java new file mode 100644 index 00000000000..d99fb4fdf75 --- /dev/null +++ b/jdk/test/java/net/SocketPermission/Wildcard.java @@ -0,0 +1,45 @@ +/* + * Copyright (c) 2011, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + * @test + * @bug 7021280 + * @summary SocketPermission should accept wildcards + */ + +import java.net.SocketPermission; + +public class Wildcard +{ + public static void main(String[] args) throws Exception { + SocketPermission star_All = + new SocketPermission("*.blabla.bla", "listen,accept,connect"); + SocketPermission www_All = + new SocketPermission("bla.blabla.bla", "listen,accept,connect"); + + if (!star_All.implies(www_All)) { + throw new RuntimeException( + "Failed: " + star_All + " does not imply " + www_All); + } + } +}