stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8217385: JTREG: Clean up, make sure to close resources

Browse Source 
Reviewed-by: tschatzl, sangheki
This commit is contained in:
Leo Korinth 2019-02-18 10:48:48 +01:00
parent 29021027db
commit 3d13ab6882
3 changed files with 36 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
test/hotspot/jtreg/gc/g1/humongousObjects/TestHumongousClassLoader.java
View File

@ -156,6 +156,7 @@ public class TestHumongousClassLoader {
URLClassLoader urlLoader = new URLClassLoader(url); URLClassLoader urlLoader = new URLClassLoader(url);
Class<?> simpleClassLoaderClass = urlLoader.loadClass(SIMPLE_CLASSLOADER_NAME); Class<?> simpleClassLoaderClass = urlLoader.loadClass(SIMPLE_CLASSLOADER_NAME);
urlLoader.close();
ClassLoader simpleClassLoader = (ClassLoader) simpleClassLoaderClass ClassLoader simpleClassLoader = (ClassLoader) simpleClassLoaderClass
.getConstructor(java.lang.ClassLoader.class) .getConstructor(java.lang.ClassLoader.class)

3
test/hotspot/jtreg/gc/g1/plab/lib/LogParser.java
View File

@ -95,7 +95,7 @@ final public class LogParser {
} }
private PlabReport parseLines() throws NumberFormatException { private PlabReport parseLines() throws NumberFormatException {
Scanner lineScanner = new Scanner(log); try (Scanner lineScanner = new Scanner(log)) {
PlabReport plabReport = new PlabReport(); PlabReport plabReport = new PlabReport();
Optional<Long> gc_id; Optional<Long> gc_id;
while (lineScanner.hasNextLine()) { while (lineScanner.hasNextLine()) {
@ -126,6 +126,7 @@ final public class LogParser {
} }
return plabReport; return plabReport;
} }
}
private static Optional<Long> getGcId(String line, Pattern pattern) { private static Optional<Long> getGcId(String line, Pattern pattern) {
Matcher number = pattern.matcher(line); Matcher number = pattern.matcher(line);

3
test/hotspot/jtreg/gc/stress/gcbasher/TestGCBasher.java
View File

@ -38,7 +38,7 @@ public class TestGCBasher {
HashMap<String, ClassInfo> deps = new HashMap<>(); HashMap<String, ClassInfo> deps = new HashMap<>();
FileSystem fs = FileSystems.getFileSystem(URI.create("jrt:/")); FileSystem fs = FileSystems.getFileSystem(URI.create("jrt:/"));
Stream<Path> s = Files.walk(fs.getPath("/")); try (Stream<Path> s = Files.walk(fs.getPath("/"))) {
for (Path p : (Iterable<Path>)s::iterator) { for (Path p : (Iterable<Path>)s::iterator) {
if (p.toString().endsWith(".class") && if (p.toString().endsWith(".class") &&
!p.getFileName().toString().equals("module-info.class")) { !p.getFileName().toString().equals("module-info.class")) {
@ -49,6 +49,7 @@ public class TestGCBasher {
} }
} }
} }
}
public static void main(String[] args) throws IOException { public static void main(String[] args) throws IOException {
if (args.length != 1) { if (args.length != 1) {