stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

6897550: BigInteger constructor should use local cached String length

Browse Source 
Reviewed-by: andrew, chegar
This commit is contained in:
Joe Darcy 2009-11-03 15:01:50 -08:00
parent d9568c4ee6
commit 3e515ef90f
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
jdk/src/share/classes/java/math/BigInteger.java
View File

@ -288,11 +288,11 @@ public class BigInteger extends Number implements Comparable<BigInteger> {
*/ */
public BigInteger(String val, int radix) { public BigInteger(String val, int radix) {
int cursor = 0, numDigits; int cursor = 0, numDigits;
int len = val.length(); final int len = val.length();
if (radix < Character.MIN_RADIX || radix > Character.MAX_RADIX) if (radix < Character.MIN_RADIX || radix > Character.MAX_RADIX)
throw new NumberFormatException("Radix out of range"); throw new NumberFormatException("Radix out of range");
if (val.length() == 0) if (len == 0)
throw new NumberFormatException("Zero length BigInteger"); throw new NumberFormatException("Zero length BigInteger");
// Check for at most one leading sign // Check for at most one leading sign
@ -303,7 +303,7 @@ public class BigInteger extends Number implements Comparable<BigInteger> {
// No leading sign character or at most one leading sign character // No leading sign character or at most one leading sign character
if (index1 == 0 || index2 == 0) { if (index1 == 0 || index2 == 0) {
cursor = 1; cursor = 1;
if (val.length() == 1) if (len == 1)
throw new NumberFormatException("Zero length BigInteger"); throw new NumberFormatException("Zero length BigInteger");
} }
if (index1 == 0) if (index1 == 0)
@ -342,7 +342,7 @@ public class BigInteger extends Number implements Comparable<BigInteger> {
// Process remaining digit groups // Process remaining digit groups
int superRadix = intRadix[radix]; int superRadix = intRadix[radix];
int groupVal = 0; int groupVal = 0;
while (cursor < val.length()) { while (cursor < len) {
group = val.substring(cursor, cursor += digitsPerInt[radix]); group = val.substring(cursor, cursor += digitsPerInt[radix]);
groupVal = Integer.parseInt(group, radix); groupVal = Integer.parseInt(group, radix);
if (groupVal < 0) if (groupVal < 0)