From 42758cb889a5cf1d7f4c4b468a383b218baa1b27 Mon Sep 17 00:00:00 2001 From: Jesse Glick Date: Thu, 10 Aug 2023 22:26:32 +0000 Subject: [PATCH] 8312882: Update the CONTRIBUTING.md with pointers to lifecycle of a PR Reviewed-by: erikj, jwilhelm --- CONTRIBUTING.md | 2 +- doc/building.html | 19 +++++-------------- doc/building.md | 15 +-------------- 3 files changed, 7 insertions(+), 29 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 990ed2b79ac..4a338235c1d 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,3 +1,3 @@ # Contributing to the JDK -Please see for how to contribute. +Please see the [OpenJDK Developers’ Guide](https://openjdk.org/guide/). diff --git a/doc/building.html b/doc/building.html index 54828da9991..c88d87f288b 100644 --- a/doc/building.html +++ b/doc/building.html @@ -324,7 +324,8 @@ GB of free disk space is required.

Even for 32-bit builds, it is recommended to use a 64-bit build machine, and instead create a 32-bit target using --with-target-bits=32.

-

Note: The Windows 32-bit x86 port is deprecated and may be removed in a future release.

+

Note: The Windows 32-bit x86 port is deprecated and may be removed in +a future release.

Building on aarch64

At a minimum, a machine with 8 cores is advisable, as well as 8 GB of RAM. (The more cores to use, the more memory you need.) At least 6 GB of @@ -401,7 +402,8 @@ to the build system, e.g. in arguments to configure. So, use --with-msvcr-dll=/cygdrive/c/msvcr100.dll rather than --with-msvcr-dll=c:\msvcr100.dll. For details on this conversion, see the section on Fixpath.

-

Note: The Windows 32-bit x86 port is deprecated and may be removed in a future release.

+

Note: The Windows 32-bit x86 port is deprecated and may be removed in +a future release.

Cygwin

A functioning Cygwin environment is required for building the JDK on Windows. If you have a 64-bit OS, we @@ -2255,18 +2257,7 @@ However, please bear in mind that the JDK is a massive project, and we must ask you to follow our rules and guidelines to be able to accept your contribution.

The official place to start is the 'How to contribute' page. -There is also an official (but somewhat outdated and skimpy on details) -Developer's Guide.

-

If this seems overwhelming to you, the Adoption Group is there to -help you! A good place to start is their 'New -Contributor' page, or start reading the comprehensive Getting -Started Kit. The Adoption Group will also happily answer any -questions you have about contributing. Contact them by mail -or IRC.

+href="https://openjdk.org/guide/">OpenJDK Developers’ Guide.

Editing this document

If you want to contribute changes to this document, edit doc/building.md and then run diff --git a/doc/building.md b/doc/building.md index d6d89d7887f..e2504d12b4a 100644 --- a/doc/building.md +++ b/doc/building.md @@ -2032,20 +2032,7 @@ First of all: Thank you! We gladly welcome your contribution. However, please bear in mind that the JDK is a massive project, and we must ask you to follow our rules and guidelines to be able to accept your contribution. -The official place to start is the ['How to contribute' page]( -http://openjdk.org/contribute/). There is also an official (but somewhat -outdated and skimpy on details) [Developer's Guide]( -http://openjdk.org/guide/). - -If this seems overwhelming to you, the Adoption Group is there to help you! A -good place to start is their ['New Contributor' page]( -https://wiki.openjdk.org/display/Adoption/New+Contributor), or start -reading the comprehensive [Getting Started Kit]( -https://adoptopenjdk.gitbooks.io/adoptopenjdk-getting-started-kit/en/). The -Adoption Group will also happily answer any questions you have about -contributing. Contact them by [mail]( -http://mail.openjdk.org/mailman/listinfo/adoption-discuss) or [IRC]( -http://openjdk.org/irc/). +The official place to start is the [OpenJDK Developers’ Guide](https://openjdk.org/guide/). ## Editing this document