stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8008589: Better MBean permission validation

Browse Source 
Better MBean permission validation

Reviewed-by: skoivu, dfuchs, mchung, sjiang
This commit is contained in:
Dmitry Samersoff 2013-07-08 16:15:39 +04:00
parent f0b7243841
commit 455cd24c95
1 changed files with 27 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
jdk/src/share/classes/javax/management/MBeanTrustPermission.java
View File

@ -26,6 +26,9 @@
package javax.management;
import java.security.BasicPermission;
import java.io.IOException;
import java.io.InvalidObjectException;
import java.io.ObjectInputStream;
/**
* This permission represents "trust" in a signer or codebase.
@ -75,15 +78,31 @@ public class MBeanTrustPermission extends BasicPermission {
*/
public MBeanTrustPermission(String name, String actions) {
super(name, actions);
/* Check that actions is a null empty string */
if (actions != null && actions.length() > 0)
throw new IllegalArgumentException("MBeanTrustPermission " +
"actions must be null: " +
actions);
validate(name,actions);
}
if (!name.equals("register") && !name.equals("*"))
throw new IllegalArgumentException("MBeanTrustPermission: " +
"Unknown target name " +
private static void validate(String name, String actions) {
/* Check that actions is a null empty string */
if (actions != null && actions.length() > 0) {
throw new IllegalArgumentException("MBeanTrustPermission actions must be null: " +
actions);
}
if (!name.equals("register") && !name.equals("*")) {
throw new IllegalArgumentException("MBeanTrustPermission: Unknown target name " +
"[" + name + "]");
}
}
private void readObject(ObjectInputStream in)
throws IOException, ClassNotFoundException {
// Reading private fields of base class
in.defaultReadObject();
try {
validate(super.getName(),super.getActions());
} catch (IllegalArgumentException e) {
throw new InvalidObjectException(e.getMessage());
}
}
}