stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8210347: Combine subsequent calls to Set.contains() and Set.add()

Browse Source 
Reviewed-by: smarks, bpb
This commit is contained in:
Ivan Gerasimov 2018-09-11 14:51:45 -07:00
parent 9118c4c28b
commit 475d422094
4 changed files with 6 additions and 10 deletions
src/java.base/share/classes/java
lang
ModuleLayer.java
module
Configuration.java
util
ServiceLoader.java
stream
DistinctOps.java

5
src/java.base/share/classes/java/lang/ModuleLayer.java

@ -1,5 +1,5 @@
/*
* Copyright (c) 2014, 2017, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2014, 2018, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@ -790,8 +790,7 @@ public final class ModuleLayer {
// push in reverse order
for (int i = layer.parents.size() - 1; i >= 0; i--) {
ModuleLayer parent = layer.parents.get(i);
if (!visited.contains(parent)) {
visited.add(parent);
if (visited.add(parent)) {
stack.push(parent);
}
}

3
src/java.base/share/classes/java/lang/module/Configuration.java

@ -601,8 +601,7 @@ public final class Configuration {
// push in reverse order
for (int i = layer.parents.size() - 1; i >= 0; i--) {
Configuration parent = layer.parents.get(i);
if (!visited.contains(parent)) {
visited.add(parent);
if (visited.add(parent)) {
stack.push(parent);
}
}

3
src/java.base/share/classes/java/util/ServiceLoader.java

@ -938,8 +938,7 @@ public final class ServiceLoader<S>
List<ModuleLayer> parents = layer.parents();
for (int i = parents.size() - 1; i >= 0; i--) {
ModuleLayer parent = parents.get(i);
if (!visited.contains(parent)) {
visited.add(parent);
if (visited.add(parent)) {
stack.push(parent);
}
}

5
src/java.base/share/classes/java/util/stream/DistinctOps.java

@ -1,5 +1,5 @@
/*
* Copyright (c) 2012, 2013, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2012, 2018, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@ -170,8 +170,7 @@ final class DistinctOps {
@Override
public void accept(T t) {
if (!seen.contains(t)) {
seen.add(t);
if (seen.add(t)) {
downstream.accept(t);
}
}