From 4a1cdd5ba947ffc88c1100966e68826eb35ed441 Mon Sep 17 00:00:00 2001 From: Albert Mingkun Yang Date: Tue, 4 Jun 2024 16:39:03 +0000 Subject: [PATCH] 8333486: Parallel: Remove unused methods in psParallelCompact Reviewed-by: tschatzl --- .../share/gc/parallel/psParallelCompact.cpp | 15 ------------- .../share/gc/parallel/psParallelCompact.hpp | 22 +++++++++---------- 2 files changed, 10 insertions(+), 27 deletions(-) diff --git a/src/hotspot/share/gc/parallel/psParallelCompact.cpp b/src/hotspot/share/gc/parallel/psParallelCompact.cpp index 367e76c8057..7b8ae42aaa4 100644 --- a/src/hotspot/share/gc/parallel/psParallelCompact.cpp +++ b/src/hotspot/share/gc/parallel/psParallelCompact.cpp @@ -280,21 +280,6 @@ PSParallelCompact::print_generic_summary_data(ParallelCompactData& summary_data, ::print_generic_summary_data(summary_data,beg_addr, end_addr); } -void -print_generic_summary_data(ParallelCompactData& summary_data, - SpaceInfo* space_info) -{ - if (!log_develop_is_enabled(Trace, gc, compaction)) { - return; - } - - for (unsigned int id = 0; id < PSParallelCompact::last_space_id; ++id) { - const MutableSpace* space = space_info[id].space(); - print_generic_summary_data(summary_data, space->bottom(), - MAX2(space->top(), space_info[id].new_top())); - } -} - static void print_initial_summary_data(ParallelCompactData& summary_data, const MutableSpace* space) { diff --git a/src/hotspot/share/gc/parallel/psParallelCompact.hpp b/src/hotspot/share/gc/parallel/psParallelCompact.hpp index 751edcd323e..8f29074b927 100644 --- a/src/hotspot/share/gc/parallel/psParallelCompact.hpp +++ b/src/hotspot/share/gc/parallel/psParallelCompact.hpp @@ -166,7 +166,7 @@ inline bool SplitInfo::is_split(size_t region_idx) const class SpaceInfo { - public: +public: MutableSpace* space() const { return _space; } // Where the free space will start after the collection. Valid only after the @@ -190,9 +190,7 @@ class SpaceInfo void set_dense_prefix(HeapWord* addr) { _dense_prefix = addr; } void set_start_array(ObjectStartArray* s) { _start_array = s; } - void publish_new_top() const { _space->set_top(_new_top); } - - private: +private: MutableSpace* _space; HeapWord* _new_top; HeapWord* _dense_prefix; @@ -681,7 +679,7 @@ ParallelCompactData::is_region_aligned(HeapWord* addr) const // https://doi.org/10.1145/3313808.3313820 class PSParallelCompact : AllStatic { - public: +public: // Convenient access to type names. typedef ParMarkBitMap::idx_t idx_t; typedef ParallelCompactData::RegionData RegionData; @@ -701,7 +699,7 @@ public: friend class PSParallelCompactTest; - private: +private: static STWGCTimer _gc_timer; static ParallelOldTracer _gc_tracer; static elapsedTimer _accumulated_time; @@ -716,10 +714,10 @@ public: static SpanSubjectToDiscoveryClosure _span_based_discoverer; static ReferenceProcessor* _ref_processor; - public: +public: static ParallelOldTracer* gc_tracer() { return &_gc_tracer; } - private: +private: static void initialize_space_info(); @@ -768,7 +766,7 @@ public: static void fill_range_in_dense_prefix(HeapWord* start, HeapWord* end); - public: +public: static void fill_dead_objs_in_dense_prefix(uint worker_id, uint num_workers); static bool invoke(bool maximum_heap_compaction); @@ -885,12 +883,12 @@ public: }; class MoveAndUpdateClosure: public StackObj { - private: +private: ParMarkBitMap* const _bitmap; size_t _words_remaining; // Words left to copy. static inline size_t calculate_words_remaining(size_t region); - protected: +protected: HeapWord* _source; // Next addr that would be read. HeapWord* _destination; // Next addr to be written. ObjectStartArray* const _start_array; @@ -900,7 +898,7 @@ class MoveAndUpdateClosure: public StackObj { // Update variables to indicate that word_count words were processed. inline void update_state(size_t words); - public: +public: typedef ParMarkBitMap::idx_t idx_t; ParMarkBitMap* bitmap() const { return _bitmap; }