stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8219497: Unused parameter in HtmlDocletWriter::printHtmlDocument

Browse Source 
Reviewed-by: hannesw
This commit is contained in:
Jonathan Gibbons 2019-02-21 15:05:47 -08:00
parent fa0093dc2c
commit 4aafd7b06e
23 changed files with 19 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractModuleIndexWriter.java
View File

@ -145,7 +145,6 @@ public abstract class AbstractModuleIndexWriter extends HtmlDocletWriter {
printHtmlDocument(
configuration.metakeywords.getOverviewMetaKeywords(title, configuration.doctitle),
description,
includeScript,
body);
}
@ -178,7 +177,6 @@ public abstract class AbstractModuleIndexWriter extends HtmlDocletWriter {
printHtmlDocument(
configuration.metakeywords.getOverviewMetaKeywords(title, configuration.doctitle),
description,
includeScript,
body);
}

2
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractPackageIndexWriter.java
View File

@ -129,7 +129,7 @@ public abstract class AbstractPackageIndexWriter extends HtmlDocletWriter {
body.addContent(footer);
printHtmlDocument(
configuration.metakeywords.getOverviewMetaKeywords(title, configuration.doctitle),
description, includeScript, body);
description, body);
}
/**

2
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllClassesFrameWriter.java
View File

@ -120,7 +120,7 @@ public class AllClassesFrameWriter extends HtmlDocletWriter {
HtmlTree div = HtmlTree.DIV(HtmlStyle.indexContainer, ul);
htmlTree.addContent(div);
body.addContent(htmlTree);
printHtmlDocument(null, "all classes (frame)", false, body);
printHtmlDocument(null, "all classes (frame)", body);
}
/**

2
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllClassesIndexWriter.java
View File

@ -116,7 +116,7 @@ public class AllClassesIndexWriter extends HtmlDocletWriter {
footer.addContent(navBar.getContent(false));
addBottom(footer);
bodyTree.addContent(footer);
printHtmlDocument(null, "class index", true, bodyTree);
printHtmlDocument(null, "class index", bodyTree);
}
/**

2
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllPackagesIndexWriter.java
View File

@ -104,7 +104,7 @@ public class AllPackagesIndexWriter extends HtmlDocletWriter {
footer.addContent(navBar.getContent(false));
addBottom(footer);
bodyTree.addContent(footer);
printHtmlDocument(null, "package index", true, bodyTree);
printHtmlDocument(null, "package index", bodyTree);
}
/**

2
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeWriterImpl.java
View File

@ -155,7 +155,7 @@ public class AnnotationTypeWriterImpl extends SubWriterHolderWriter
PackageElement pkg = utils.containingPackage(this.annotationType);
Content stylesheetContent = getLocalStylesheetContent(pkg);
printHtmlDocument(configuration.metakeywords.getMetaKeywords(annotationType),
description, true, stylesheetContent, contentTree);
description, stylesheetContent, contentTree);
}
/**

2
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassUseWriter.java
View File

@ -240,7 +240,7 @@ public class ClassUseWriter extends SubWriterHolderWriter {
addBottom(footer);
body.addContent(footer);
String description = getDescription("use", typeElement);
printHtmlDocument(null, description, true, body);
printHtmlDocument(null, description, body);
}
/**

2
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassWriterImpl.java
View File

@ -180,7 +180,7 @@ public class ClassWriterImpl extends SubWriterHolderWriter implements ClassWrite
PackageElement pkg = utils.containingPackage(typeElement);
Content stylesheetContent = getLocalStylesheetContent(pkg);
printHtmlDocument(configuration.metakeywords.getMetaKeywords(typeElement),
description, true, stylesheetContent, contentTree);
description, stylesheetContent, contentTree);
}
/**

2
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ConstantsSummaryWriterImpl.java
View File

@ -327,6 +327,6 @@ public class ConstantsSummaryWriterImpl extends HtmlDocletWriter implements Cons
*/
@Override
public void printDocument(Content contentTree) throws DocFileIOException {
printHtmlDocument(null, "summary of constants", true, contentTree);
printHtmlDocument(null, "summary of constants", contentTree);
}
}

2
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/DeprecatedListWriter.java
View File

@ -308,7 +308,7 @@ public class DeprecatedListWriter extends SubWriterHolderWriter {
addBottom(htmlTree);
body.addContent(htmlTree);
String description = "deprecated elements";
printHtmlDocument(null, description, true, body);
printHtmlDocument(null, description, body);
}
/**

2
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/DocFilesHandlerImpl.java
View File

@ -206,7 +206,7 @@ public class DocFilesHandlerImpl implements DocFilesHandler {
footer.addContent(navBar.getContent(false));
docletWriter.addBottom(footer);
htmlContent.addContent(footer);
docletWriter.printHtmlDocument(Collections.emptyList(), null, false, localTagsContent, htmlContent);
docletWriter.printHtmlDocument(Collections.emptyList(), null, localTagsContent, htmlContent);
}

2
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HelpWriter.java
View File

@ -99,7 +99,7 @@ public class HelpWriter extends HtmlDocletWriter {
htmlTree.addContent(navBar.getContent(false));
addBottom(htmlTree);
body.addContent(htmlTree);
printHtmlDocument(null, "help", true, body);
printHtmlDocument(null, "help", body);
}
/**

8
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java
View File

@ -423,17 +423,14 @@ public class HtmlDocletWriter {
* of the array is assigned to a separate META tag.
* Pass in null for no array
* @param description the content for the description META tag.
* @param includeScript true if printing windowtitle script
* false for files that appear in the left-hand frames
* @param body the body htmltree to be included in the document
* @throws DocFileIOException if there is a problem writing the file
*/
public void printHtmlDocument(List<String> metakeywords,
String description,
boolean includeScript,
Content body)
throws DocFileIOException {
printHtmlDocument(metakeywords, description, includeScript, new ContentBuilder(), body);
printHtmlDocument(metakeywords, description, new ContentBuilder(), body);
}
/**
@ -443,15 +440,12 @@ public class HtmlDocletWriter {
* of the array is assigned to a separate META tag.
* Pass in null for no array
* @param description the content for the description META tag.
* @param includeScript true if printing windowtitle script
* false for files that appear in the left-hand frames
* @param extraHeadContent any additional content to be included in the HEAD element
* @param body the body htmltree to be included in the document
* @throws DocFileIOException if there is a problem writing the file
*/
public void printHtmlDocument(List<String> metakeywords,
String description,
boolean includeScript,
Content extraHeadContent,
Content body)
throws DocFileIOException {

1
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleFrameWriter.java
View File

@ -111,7 +111,6 @@ public class ModuleFrameWriter extends HtmlDocletWriter {
mdlgen.printHtmlDocument(
configuration.metakeywords.getMetaKeywordsForModule(moduleElement),
"module summary (frame)",
false,
body);
}

2
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleWriterImpl.java
View File

@ -915,7 +915,7 @@ public class ModuleWriterImpl extends HtmlDocletWriter implements ModuleSummaryW
public void printDocument(Content contentTree) throws DocFileIOException {
printHtmlDocument(configuration.metakeywords.getMetaKeywordsForModule(mdle),
getDescription("declaration", mdle),
true, contentTree);
contentTree);
}
/**

1
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageFrameWriter.java
View File

@ -112,7 +112,6 @@ public class PackageFrameWriter extends HtmlDocletWriter {
packgen.printHtmlDocument(
configuration.metakeywords.getMetaKeywords(packageElement),
getDescription("package summary (frame)", packageElement),
false,
body);
}

2
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageTreeWriter.java
View File

@ -120,7 +120,7 @@ public class PackageTreeWriter extends AbstractTreeWriter {
footer.addContent(navBar.getContent(false));
addBottom(footer);
body.addContent(footer);
printHtmlDocument(null, getDescription("tree", packageElement), true, body);
printHtmlDocument(null, getDescription("tree", packageElement), body);
}
/**

1
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageUseWriter.java
View File

@ -142,7 +142,6 @@ public class PackageUseWriter extends SubWriterHolderWriter {
body.addContent(footer);
printHtmlDocument(null,
getDescription("use", packageElement),
true,
body);
}

2
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageWriterImpl.java
View File

@ -318,6 +318,6 @@ public class PackageWriterImpl extends HtmlDocletWriter
String description = getDescription("declaration", packageElement);
Content stylesheetContent = getLocalStylesheetContent(packageElement);
printHtmlDocument(configuration.metakeywords.getMetaKeywords(packageElement),
description, true, stylesheetContent, contentTree);
description, stylesheetContent, contentTree);
}
}

2
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SerializedFormWriterImpl.java
View File

@ -253,7 +253,7 @@ public class SerializedFormWriterImpl extends SubWriterHolderWriter
*/
@Override
public void printDocument(Content serializedTree) throws DocFileIOException {
printHtmlDocument(null, "serialized forms", true, serializedTree);
printHtmlDocument(null, "serialized forms", serializedTree);
}
/**

2
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SingleIndexWriter.java
View File

@ -121,7 +121,7 @@ public class SingleIndexWriter extends AbstractIndexWriter {
addBottom(htmlTree);
body.addContent(htmlTree);
createSearchIndexFiles();
printHtmlDocument(null, "index", true, body);
printHtmlDocument(null, "index", body);
}
/**

2
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SplitIndexWriter.java
View File

@ -145,7 +145,7 @@ public class SplitIndexWriter extends AbstractIndexWriter {
addBottom(footer);
body.addContent(footer);
String description = "index: " + unicode;
printHtmlDocument(null, description, true, body);
printHtmlDocument(null, description, body);
}
/**

2
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TreeWriter.java
View File

@ -126,7 +126,7 @@ public class TreeWriter extends AbstractTreeWriter {
htmlTree.addContent(navBar.getContent(false));
addBottom(htmlTree);
body.addContent(htmlTree);
printHtmlDocument(null, "class tree", true, body);
printHtmlDocument(null, "class tree", body);
}
/**