8086027: Multiple STATIC_ASSERTs at class scope doesn't work

Make supporting typedef name unique via __LINE__ concatenation

Reviewed-by: dholmes, brutisso
This commit is contained in:
Kim Barrett 2015-06-09 15:05:47 -04:00
parent f286447281
commit 4bbbdd7aa6
3 changed files with 39 additions and 1 deletions

View File

@ -770,3 +770,31 @@ extern "C" void pns(void* sp, void* fp, void* pc) { // print native stack
} }
#endif // !PRODUCT #endif // !PRODUCT
//////////////////////////////////////////////////////////////////////////////
// Test multiple STATIC_ASSERT forms in various scopes.
#ifndef PRODUCT
// namespace scope
STATIC_ASSERT(true);
STATIC_ASSERT(true);
STATIC_ASSERT(1 == 1);
STATIC_ASSERT(0 == 0);
void test_multiple_static_assert_forms_in_function_scope() {
STATIC_ASSERT(true);
STATIC_ASSERT(true);
STATIC_ASSERT(0 == 0);
STATIC_ASSERT(1 == 1);
}
// class scope
struct TestMultipleStaticAssertFormsInClassScope {
STATIC_ASSERT(true);
STATIC_ASSERT(true);
STATIC_ASSERT(0 == 0);
STATIC_ASSERT(1 == 1);
};
#endif // !PRODUCT

View File

@ -223,7 +223,8 @@ template<bool x> struct STATIC_ASSERT_FAILURE;
template<> struct STATIC_ASSERT_FAILURE<true> { enum { value = 1 }; }; template<> struct STATIC_ASSERT_FAILURE<true> { enum { value = 1 }; };
#define STATIC_ASSERT(Cond) \ #define STATIC_ASSERT(Cond) \
typedef char STATIC_ASSERT_DUMMY_TYPE[ STATIC_ASSERT_FAILURE< (Cond) >::value ] typedef char PASTE_TOKENS(STATIC_ASSERT_DUMMY_TYPE_, __LINE__)[ \
STATIC_ASSERT_FAILURE< (Cond) >::value ]
// out of shared space reporting // out of shared space reporting
enum SharedSpaceType { enum SharedSpaceType {

View File

@ -34,6 +34,15 @@
// Makes a string of the macro expansion of a // Makes a string of the macro expansion of a
#define XSTR(a) STR(a) #define XSTR(a) STR(a)
// Apply pre-processor token pasting to the expansions of x and y.
// The token pasting operator (##) prevents its arguments from being
// expanded. This macro allows expansion of its arguments before the
// concatenation is performed. Note: One auxilliary level ought to be
// sufficient, but two are used because of bugs in some preprocesors.
#define PASTE_TOKENS(x, y) PASTE_TOKENS_AUX(x, y)
#define PASTE_TOKENS_AUX(x, y) PASTE_TOKENS_AUX2(x, y)
#define PASTE_TOKENS_AUX2(x, y) x ## y
// -DINCLUDE_<something>=0 | 1 can be specified on the command line to include // -DINCLUDE_<something>=0 | 1 can be specified on the command line to include
// or exclude functionality. // or exclude functionality.