stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8056050: runExternalJsTest method in test/jdk/nashorn/internal/runtime/ClassFilter.java slows down "ant test"

Browse Source 
Reviewed-by: attila, jlaskey
This commit is contained in:
Athijegannathan Sundararajan 2014-08-26 17:21:17 +05:30
parent 362089dbfc
commit 4bca3ec0bf
1 changed files with 20 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
nashorn/test/src/jdk/nashorn/internal/runtime/ClassFilterTest.java
View File

@ -38,10 +38,15 @@ import java.io.File;
import static org.testng.Assert.fail; import static org.testng.Assert.fail;
public class ClassFilterTest { public class ClassFilterTest {
private static final String NASHORN_CODE_CACHE = "nashorn.persistent.code.cache";
private static final String CLASSFILTER_CODE_CACHE = "build/classfilter_nashorn_code_cache";
private final String codeCache = "build/nashorn_code_cache"; // @Test
// This test takes too much time for basic "ant clean test" run.
@Test // Given that "allow-all-java-classes" is equivalent to no java class
// filter and external tests don't access any java, not sure if this
// test contributes much. We need faster "ant clean test" cycle for
// developers.
public void runExternalJsTest() { public void runExternalJsTest() {
String[] paths = new String[]{ String[] paths = new String[]{
"test/script/basic/compile-octane.js", "test/script/basic/compile-octane.js",
@ -107,7 +112,18 @@ public class ClassFilterTest {
@Test @Test
public void persistentCacheTest() { public void persistentCacheTest() {
System.setProperty("nashorn.persistent.code.cache", codeCache); final String oldCodeCache = System.getProperty(NASHORN_CODE_CACHE);
System.setProperty(NASHORN_CODE_CACHE, CLASSFILTER_CODE_CACHE);
try {
persistentCacheTestImpl();
} finally {
if (oldCodeCache != null) {
System.setProperty(NASHORN_CODE_CACHE, oldCodeCache);
}
}
}
private void persistentCacheTestImpl() {
NashornScriptEngineFactory factory = new NashornScriptEngineFactory(); NashornScriptEngineFactory factory = new NashornScriptEngineFactory();
ScriptEngine engine = factory.getScriptEngine( ScriptEngine engine = factory.getScriptEngine(
new String[]{"--persistent-code-cache"}, new String[]{"--persistent-code-cache"},