stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8322133: getParameterSpec(ECGenParameterSpec.class) on EC AlgorithmParameters does not return standard names

Browse Source 
Reviewed-by: mullan
This commit is contained in:
Ben Perez 2024-07-23 19:35:11 +00:00 committed by Sean Mullan
parent 2f2223d752
commit 4c91d5cb41
2 changed files with 49 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/java.base/share/classes/sun/security/util/ECParameters.java
View File

@ -1,5 +1,5 @@
/*
* Copyright (c) 2006, 2022, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2006, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@ -203,8 +203,7 @@ public final class ECParameters extends AlgorithmParametersSpi {
}
if (spec.isAssignableFrom(ECGenParameterSpec.class)) {
// Ensure the name is the Object ID
String name = namedCurve.getObjectId();
String name = namedCurve.getNameAndAliases()[0];
return spec.cast(new ECGenParameterSpec(name));
}

47
test/jdk/com/sun/crypto/provider/AlgorithmParameters/EC/CurveGetParameterSpec.java Normal file
View File

@ -0,0 +1,47 @@
/*
* Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 8322133
* @summary Make sure getParameterSpec returns std name for EC AlgorithmParameters
* @modules java.base/sun.security.util
*/
import java.security.AlgorithmParameters;
import java.security.KeyPairGenerator;
import java.security.spec.ECGenParameterSpec;
public class CurveGetParameterSpec {
public static void main(String[] args) throws Exception {
KeyPairGenerator kpg = KeyPairGenerator.getInstance("EC");
kpg.initialize(new ECGenParameterSpec("secp384r1"));
var k = kpg.generateKeyPair().getPublic();
var a = AlgorithmParameters.getInstance("EC");
a.init(k.getParams());
String name = a.getParameterSpec(ECGenParameterSpec.class).getName();
if (!name.equals("secp384r1")) {
throw new Exception("EC getParameterSpec does not return std name secp384r1. Instead returns: " + name);
}
}
}