stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8284620: CodeBuffer may leak _overflow_arena

Browse Source 
Reviewed-by: thartmann, kvn
This commit is contained in:
Zhengyu Gu 2022-04-11 19:04:45 +00:00
parent 73aa5551e1
commit 4d45c3ebc4
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/hotspot/share/asm/codeBuffer.cpp
View File

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 1997, 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
* *
* This code is free software; you can redistribute it and/or modify it * This code is free software; you can redistribute it and/or modify it
@ -133,11 +133,10 @@ CodeBuffer::~CodeBuffer() {
// Previous incarnations of this buffer are held live, so that internal // Previous incarnations of this buffer are held live, so that internal
// addresses constructed before expansions will not be confused. // addresses constructed before expansions will not be confused.
cb->free_blob(); cb->free_blob();
// free any overflow storage
delete cb->_overflow_arena;
} }
// free any overflow storage
delete _overflow_arena;
NOT_PRODUCT(clear_strings()); NOT_PRODUCT(clear_strings());
assert(_default_oop_recorder.allocated_on_stack_or_embedded(), "should be embedded object"); assert(_default_oop_recorder.allocated_on_stack_or_embedded(), "should be embedded object");
@ -932,6 +931,7 @@ void CodeBuffer::take_over_code_from(CodeBuffer* cb) {
this_sect->take_over_code_from(cb_sect); this_sect->take_over_code_from(cb_sect);
} }
_overflow_arena = cb->_overflow_arena; _overflow_arena = cb->_overflow_arena;
cb->_overflow_arena = NULL;
// Make sure the old cb won't try to use it or free it. // Make sure the old cb won't try to use it or free it.
DEBUG_ONLY(cb->_blob = (BufferBlob*)badAddress); DEBUG_ONLY(cb->_blob = (BufferBlob*)badAddress);
} }