stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8314389: AttachListener::pd_set_flag obsolete

Browse Source 
Reviewed-by: cjplummer, mdoerr, sspitsyn
This commit is contained in:
Matthias Baesken 2023-08-18 06:45:18 +00:00
parent 891c3f4cca
commit 5058854b86
6 changed files with 1 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/hotspot/os/aix/attachListener_aix.cpp
View File

@ -579,11 +579,6 @@ void AttachListener::pd_data_dump() {
os::signal_notify(SIGQUIT); os::signal_notify(SIGQUIT);
} }
jint AttachListener::pd_set_flag(AttachOperation* op, outputStream* out) {
out->print_cr("flag '%s' cannot be changed", op->arg(0));
return JNI_ERR;
}
void AttachListener::pd_detachall() { void AttachListener::pd_detachall() {
// Cleanup server socket to detach clients. // Cleanup server socket to detach clients.
listener_cleanup(); listener_cleanup();

5
src/hotspot/os/bsd/attachListener_bsd.cpp
View File

@ -542,11 +542,6 @@ void AttachListener::pd_data_dump() {
os::signal_notify(SIGQUIT); os::signal_notify(SIGQUIT);
} }
jint AttachListener::pd_set_flag(AttachOperation* op, outputStream* out) {
out->print_cr("flag '%s' cannot be changed", op->arg(0));
return JNI_ERR;
}
void AttachListener::pd_detachall() { void AttachListener::pd_detachall() {
// do nothing for now // do nothing for now
} }

5
src/hotspot/os/linux/attachListener_linux.cpp
View File

@ -547,11 +547,6 @@ void AttachListener::pd_data_dump() {
os::signal_notify(SIGQUIT); os::signal_notify(SIGQUIT);
} }
jint AttachListener::pd_set_flag(AttachOperation* op, outputStream* out) {
out->print_cr("flag '%s' cannot be changed", op->arg(0));
return JNI_ERR;
}
void AttachListener::pd_detachall() { void AttachListener::pd_detachall() {
// do nothing for now // do nothing for now
} }

5
src/hotspot/os/windows/attachListener_windows.cpp
View File

@ -391,11 +391,6 @@ void AttachListener::pd_data_dump() {
os::signal_notify(SIGBREAK); os::signal_notify(SIGBREAK);
} }
jint AttachListener::pd_set_flag(AttachOperation* op, outputStream* out) {
out->print_cr("flag '%s' cannot be changed", op->arg(0));
return JNI_ERR;
}
void AttachListener::pd_detachall() { void AttachListener::pd_detachall() {
// do nothing for now // do nothing for now
} }

5
src/hotspot/share/services/attachListener.cpp
View File

@ -319,13 +319,10 @@ static jint set_flag(AttachOperation* op, outputStream* out) {
int ret = WriteableFlags::set_flag(op->arg(0), op->arg(1), JVMFlagOrigin::ATTACH_ON_DEMAND, err_msg); int ret = WriteableFlags::set_flag(op->arg(0), op->arg(1), JVMFlagOrigin::ATTACH_ON_DEMAND, err_msg);
if (ret != JVMFlag::SUCCESS) { if (ret != JVMFlag::SUCCESS) {
if (ret == JVMFlag::NON_WRITABLE) { if (ret == JVMFlag::NON_WRITABLE) {
// if the flag is not manageable try to change it through out->print_cr("flag '%s' cannot be changed", op->arg(0));
// the platform dependent implementation
return AttachListener::pd_set_flag(op, out);
} else { } else {
out->print_cr("%s", err_msg.buffer()); out->print_cr("%s", err_msg.buffer());
} }
return JNI_ERR; return JNI_ERR;
} }
return JNI_OK; return JNI_OK;

3
src/hotspot/share/services/attachListener.hpp
View File

@ -121,9 +121,6 @@ class AttachListener: AllStatic {
// platform specific initialization // platform specific initialization
static int pd_init(); static int pd_init();
// platform specific flag change
static jint pd_set_flag(AttachOperation* op, outputStream* out);
// platform specific detachall // platform specific detachall
static void pd_detachall(); static void pd_detachall();