stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8252957: Wrong comment in CgroupV1Subsystem::cpu_quota

Browse Source 
The comment is wrong. The 'us' in 'cpu.cfs_quota_us' stands for
microseconds, which is read verbatim. Similarly for cgroups v2
all units in 'cpu.max' are in microseconds.

Reviewed-by: shade, hseigel
This commit is contained in:
Severin Gehwolf 2020-09-09 13:53:10 +00:00
parent 6329de4504
commit 5166094647
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp
View File

@ -203,11 +203,11 @@ char * CgroupV1Subsystem::cpu_cpuset_memory_nodes() {
/* cpu_quota
*
* Return the number of milliseconds per period
* Return the number of microseconds per period
* process is guaranteed to run.
*
* return:
* quota time in milliseconds
* quota time in microseconds
* -1 for no quota
* OSCONTAINER_ERROR for not supported
*/

4
src/hotspot/os/linux/cgroupV2Subsystem_linux.cpp
View File

@ -74,11 +74,11 @@ int CgroupV2Subsystem::cpu_shares() {
/* cpu_quota
*
* Return the number of milliseconds per period
* Return the number of microseconds per period
* process is guaranteed to run.
*
* return:
* quota time in milliseconds
* quota time in microseconds
* -1 for no quota
* OSCONTAINER_ERROR for not supported
*/