stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8217447: Develop flag TraceICs is broken

Browse Source 
Added NULL check and fixed output.

Reviewed-by: kvn
This commit is contained in:
Tobias Hartmann 2019-01-22 08:47:01 +01:00
parent 83cd7a3fc1
commit 5172199ef9
2 changed files with 43 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/hotspot/share/code/compiledIC.cpp
View File

@ -482,10 +482,10 @@ bool CompiledIC::set_to_monomorphic(CompiledICInfo& info) {
if (TraceICs) { if (TraceICs) {
ResourceMark rm(thread); ResourceMark rm(thread);
assert(info.cached_metadata() == NULL || info.cached_metadata()->is_klass(), "must be"); assert(info.cached_metadata() == NULL || info.cached_metadata()->is_klass(), "must be");
tty->print_cr ("IC@" INTPTR_FORMAT ": monomorphic to compiled (rcvr klass) %s: %s", tty->print_cr ("IC@" INTPTR_FORMAT ": monomorphic to compiled (rcvr klass = %s) %s",
p2i(instruction_address()), p2i(instruction_address()),
((Klass*)info.cached_metadata())->print_value_string(), (info.cached_metadata() != NULL) ? ((Klass*)info.cached_metadata())->print_value_string() : "NULL",
(safe) ? "" : "via stub"); (safe) ? "" : " via stub");
} }
} }
// We can't check this anymore. With lazy deopt we could have already // We can't check this anymore. With lazy deopt we could have already

40
test/hotspot/jtreg/compiler/arguments/TestTraceICs.java Normal file
View File

@ -0,0 +1,40 @@
/*
* Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 8217447
* @summary Test running TraceICs enabled.
* @run main/othervm -XX:+IgnoreUnrecognizedVMOptions -XX:+TraceICs
* compiler.arguments.TestTraceICs
*/
package compiler.arguments;
public class TestTraceICs {
static public void main(String[] args) {
System.out.println("Passed");
}
}