stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8058479: serviceability/dcmd/CodeCacheTest.java fails

Browse Source 
Don't parse really large hex values into a long

Reviewed-by: kvn, anoll
This commit is contained in:
Nils Eliasson 2014-09-19 10:31:03 +02:00
parent c82c59cd8f
commit 53bec16184
1 changed files with 7 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
hotspot/test/serviceability/dcmd/CodeCacheTest.java
View File

@ -80,22 +80,15 @@ public class CodeCacheTest {
line = r.readLine();
m = line2.matcher(line);
if (m.matches()) {
long start = Long.parseLong(m.group(1), 16);
if (start < 0) {
String start = m.group(1);
String mark = m.group(2);
String top = m.group(3);
// Lexical compare of hex numbers to check that they look sane.
if (start.compareTo(mark) > 1) {
throw new Exception("Failed parsing dcmd codecache output");
}
long mark = Long.parseLong(m.group(2), 16);
if (mark < 0) {
throw new Exception("Failed parsing dcmd codecache output");
}
long top = Long.parseLong(m.group(3), 16);
if (top < 0) {
throw new Exception("Failed parsing dcmd codecache output");
}
if (start > mark) {
throw new Exception("Failed parsing dcmd codecache output");
}
if (mark > top) {
if (mark.compareTo(top) > 1) {
throw new Exception("Failed parsing dcmd codecache output");
}
} else {