8274392: Suppress more warnings on non-serializable non-transient instance fields in java.sql.rowset

Reviewed-by: bpb, lancea
This commit is contained in:
Joe Darcy 2021-09-27 19:57:26 +00:00
parent 0865120e95
commit 5b660f3347
7 changed files with 18 additions and 5 deletions

@ -60,6 +60,7 @@ public class CachedRowSetImpl extends BaseRowSet implements RowSet, RowSetIntern
/** /**
* The <code>SyncProvider</code> used by the CachedRowSet * The <code>SyncProvider</code> used by the CachedRowSet
*/ */
@SuppressWarnings("serial")
private SyncProvider provider; private SyncProvider provider;
/** /**
@ -68,6 +69,7 @@ public class CachedRowSetImpl extends BaseRowSet implements RowSet, RowSetIntern
* reader as part of its implementation. * reader as part of its implementation.
* @serial * @serial
*/ */
@SuppressWarnings("serial")
private RowSetReader rowSetReader; private RowSetReader rowSetReader;
/** /**
@ -76,6 +78,7 @@ public class CachedRowSetImpl extends BaseRowSet implements RowSet, RowSetIntern
* this writer as part of its implementation. * this writer as part of its implementation.
* @serial * @serial
*/ */
@SuppressWarnings("serial")
private RowSetWriter rowSetWriter; private RowSetWriter rowSetWriter;
/** /**
@ -315,6 +318,7 @@ public class CachedRowSetImpl extends BaseRowSet implements RowSet, RowSetIntern
/** /**
* The field object for a transactional RowSet writer * The field object for a transactional RowSet writer
*/ */
@SuppressWarnings("serial")
private TransactionalWriter tWriter = null; private TransactionalWriter tWriter = null;
protected transient JdbcRowSetResourceBundle resBundle; protected transient JdbcRowSetResourceBundle resBundle;

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2003, 2013, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 2003, 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
* *
* This code is free software; you can redistribute it and/or modify it * This code is free software; you can redistribute it and/or modify it
@ -47,6 +47,7 @@ import com.sun.rowset.internal.*;
public class FilteredRowSetImpl extends WebRowSetImpl implements Serializable, Cloneable, FilteredRowSet { public class FilteredRowSetImpl extends WebRowSetImpl implements Serializable, Cloneable, FilteredRowSet {
@SuppressWarnings("serial")
private Predicate p; private Predicate p;
private boolean onInsertRow = false; private boolean onInsertRow = false;

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2003, 2019, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 2003, 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
* *
* This code is free software; you can redistribute it and/or modify it * This code is free software; you can redistribute it and/or modify it
@ -48,6 +48,7 @@ public class JdbcRowSetImpl extends BaseRowSet implements JdbcRowSet, Joinable {
* current connection to the database. This field is set * current connection to the database. This field is set
* internally when the connection is established. * internally when the connection is established.
*/ */
@SuppressWarnings("serial")
private Connection conn; private Connection conn;
/** /**
@ -56,6 +57,7 @@ public class JdbcRowSetImpl extends BaseRowSet implements JdbcRowSet, Joinable {
* {@code execute} creates the {@code PreparedStatement} * {@code execute} creates the {@code PreparedStatement}
* object. * object.
*/ */
@SuppressWarnings("serial")
private PreparedStatement ps; private PreparedStatement ps;
/** /**
@ -64,6 +66,7 @@ public class JdbcRowSetImpl extends BaseRowSet implements JdbcRowSet, Joinable {
* {@code execute} executes the rowset's command and thereby * {@code execute} executes the rowset's command and thereby
* creates the rowset's {@code ResultSet} object. * creates the rowset's {@code ResultSet} object.
*/ */
@SuppressWarnings("serial")
private ResultSet rs; private ResultSet rs;
/** /**
@ -80,6 +83,7 @@ public class JdbcRowSetImpl extends BaseRowSet implements JdbcRowSet, Joinable {
* {@code RowSetMetaDataImpl} is formed and which helps in getting * {@code RowSetMetaDataImpl} is formed and which helps in getting
* the metadata information. * the metadata information.
*/ */
@SuppressWarnings("serial")
private ResultSetMetaData resMD; private ResultSetMetaData resMD;

@ -108,6 +108,7 @@ public class JoinRowSetImpl extends WebRowSetImpl implements JoinRowSet {
* object to leverage the properties and methods of a <code>WebRowSet</code> * object to leverage the properties and methods of a <code>WebRowSet</code>
* object. * object.
*/ */
@SuppressWarnings("serial")
private WebRowSet wrs; private WebRowSet wrs;

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2003, 2013, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 2003, 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
* *
* This code is free software; you can redistribute it and/or modify it * This code is free software; you can redistribute it and/or modify it
@ -68,6 +68,7 @@ public class WebRowSetImpl extends CachedRowSetImpl implements WebRowSet {
*/ */
private int curPosBfrWrite; private int curPosBfrWrite;
@SuppressWarnings("serial")
private SyncProvider provider; private SyncProvider provider;
/** /**

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2003, 2013, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 2003, 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
* *
* This code is free software; you can redistribute it and/or modify it * This code is free software; you can redistribute it and/or modify it
@ -165,6 +165,7 @@ public class CachedRowSetWriter implements TransactionalWriter, Serializable {
* *
* @serial * @serial
*/ */
@SuppressWarnings("serial")
private ResultSetMetaData callerMd; private ResultSetMetaData callerMd;
/** /**

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2004, 2019, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 2004, 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
* *
* This code is free software; you can redistribute it and/or modify it * This code is free software; you can redistribute it and/or modify it
@ -96,6 +96,7 @@ public class SyncResolverImpl extends CachedRowSetImpl implements SyncResolver {
* SyncResolver values. Synchronization takes place on a row by * SyncResolver values. Synchronization takes place on a row by
* row basis encapsulated as a CahedRowSet. * row basis encapsulated as a CahedRowSet.
*/ */
@SuppressWarnings("serial")
private CachedRowSet row; private CachedRowSet row;
private JdbcRowSetResourceBundle resBundle; private JdbcRowSetResourceBundle resBundle;