stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8309688: Data race on java.io.ClassCache$CacheRef.strongReferent

Browse Source 
Reviewed-by: rriggs, shade
This commit is contained in:
Man Cao 2023-06-15 20:13:36 +00:00
parent 81bfd78901
commit 5c705166da
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/java.base/share/classes/java/io/ClassCache.java
View File

@ -39,6 +39,11 @@ abstract class ClassCache<T> {
private static class CacheRef<T> extends SoftReference<T> { private static class CacheRef<T> extends SoftReference<T> {
private final Class<?> type; private final Class<?> type;
// This field is deliberately accessed without sychronization. ClassValue
// provides synchronization when CacheRef is published. However, when
// a thread reads this field, while another thread is clearing the field, it
// would formally constitute a data race. But that data race is benign, and
// fixing it could introduce noticeable performance penalty, see JDK-8309688.
private T strongReferent; private T strongReferent;
CacheRef(T referent, ReferenceQueue<T> queue, Class<?> type) { CacheRef(T referent, ReferenceQueue<T> queue, Class<?> type) {