stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

6787009: (attach) Stub injection potentially unsafe on windows-x64

Browse Source 
Reviewed-by: mchung
This commit is contained in:
Alan Bateman 2008-12-22 19:28:49 +00:00
parent 3505c577b7
commit 5fa8ada075
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
jdk/src/windows/native/sun/tools/attach/WindowsVirtualMachine.c
View File

@ -345,7 +345,6 @@ JNIEXPORT void JNICALL Java_sun_tools_attach_WindowsVirtualMachine_enqueue
DataBlock data; DataBlock data;
DataBlock* pData; DataBlock* pData;
DWORD* pCode; DWORD* pCode;
DWORD numBytes;
DWORD stubLen; DWORD stubLen;
HANDLE hProcess, hThread; HANDLE hProcess, hThread;
jint argsLen, i; jint argsLen, i;
@ -400,7 +399,7 @@ JNIEXPORT void JNICALL Java_sun_tools_attach_WindowsVirtualMachine_enqueue
JNU_ThrowIOExceptionWithLastError(env, "VirtualAllocEx failed"); JNU_ThrowIOExceptionWithLastError(env, "VirtualAllocEx failed");
return; return;
} }
WriteProcessMemory( hProcess, (LPVOID)pData, (LPVOID)&data, (DWORD)sizeof(DataBlock), &numBytes ); WriteProcessMemory( hProcess, (LPVOID)pData, (LPCVOID)&data, (SIZE_T)sizeof(DataBlock), NULL );
stubLen = (DWORD)(*env)->GetArrayLength(env, stub); stubLen = (DWORD)(*env)->GetArrayLength(env, stub);
@ -412,7 +411,7 @@ JNIEXPORT void JNICALL Java_sun_tools_attach_WindowsVirtualMachine_enqueue
VirtualFreeEx(hProcess, pData, 0, MEM_RELEASE); VirtualFreeEx(hProcess, pData, 0, MEM_RELEASE);
return; return;
} }
WriteProcessMemory( hProcess, (LPVOID)pCode, (LPVOID)stubCode, (DWORD)stubLen, &numBytes ); WriteProcessMemory( hProcess, (LPVOID)pCode, (LPCVOID)stubCode, (SIZE_T)stubLen, NULL );
if (isCopy) { if (isCopy) {
(*env)->ReleaseByteArrayElements(env, stub, stubCode, JNI_ABORT); (*env)->ReleaseByteArrayElements(env, stub, stubCode, JNI_ABORT);
} }